Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode logo support for BBB #1705

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

SamuelWei
Copy link
Collaborator

Fixes #1399

Do not merge until BBB 3.0 is released

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Add dark mode logo support for BBB

Other information

@SamuelWei SamuelWei linked an issue Dec 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 31.81818% with 15 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (28d4534) to head (d03272a).

Files with missing lines Patch % Lines
resources/js/views/AdminSettings.vue 0.00% 10 Missing ⚠️
app/Http/Controllers/api/v1/SettingsController.php 42.85% 4 Missing ⚠️
app/Services/MeetingService.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1705      +/-   ##
=============================================
- Coverage      81.05%   78.58%   -2.48%     
- Complexity      1340     1344       +4     
=============================================
  Files            361      361              
  Lines           9223     9245      +22     
  Branches         851      855       +4     
=============================================
- Hits            7476     7265     -211     
- Misses          1747     1980     +233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 13, 2024

PILOS    Run #1426

Run Properties:  status check failed Failed #1426  •  git commit d03272a258: Add dark mode logo support for BBB
Project PILOS
Branch Review 1399-add-dark-mode-logo-for-bbb
Run status status check failed Failed #1426
Run duration 04m 57s
Commit git commit d03272a258: Add dark mode logo support for BBB
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 236
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/Frontend/e2e/RoomsViewDescription.cy.js • 1 failed test • Frontend tests

View Output

Test Artifacts
Rooms view description > edit description Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dark mode logo for BBB
1 participant