-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling in room stats and attendance #1600
Draft
SamuelWei
wants to merge
4
commits into
develop
Choose a base branch
from
1535-improve-error-handling-in-room-history-components
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Improve error handling in room stats and attendance #1600
SamuelWei
wants to merge
4
commits into
develop
from
1535-improve-error-handling-in-room-history-components
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1600 +/- ##
==============================================
- Coverage 80.85% 62.77% -18.08%
==============================================
Files 359 157 -202
Lines 9141 4559 -4582
Branches 845 853 +8
==============================================
- Hits 7391 2862 -4529
+ Misses 1750 1697 -53 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
PILOS Run #1143
Run Properties:
|
Project |
PILOS
|
Branch Review |
1535-improve-error-handling-in-room-history-components
|
Run status |
Failed #1143
|
Run duration | 12m 53s |
Commit |
89eb069b9f: Improve error handling in room stats and attendance
|
Committer | Samuel Weirich |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
2
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
234
|
View all changes introduced in this branch ↗︎ |
Tests for review
tests/Frontend/e2e/RoomsViewHistoryMeetingActions.cy.js • 2 failed tests • Frontend tests
Test | Artifacts | |
---|---|---|
Rooms view history meeting actions > show stats |
Test Replay
Screenshots
|
|
Rooms view history meeting actions > show attendance |
Test Replay
Screenshots
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1535
Type (Highlight the corresponding type)
Checklist
Changes