Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling in room stats and attendance #1600

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

SamuelWei
Copy link
Collaborator

Fixes #1535

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.): Error Handling
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Improve error handling in room statistics dialog
  • Improve error handling in room attendance dialog

@SamuelWei SamuelWei linked an issue Nov 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 26 lines in your changes missing coverage. Please review.

Project coverage is 62.77%. Comparing base (1b6e457) to head (89eb069).

Files with missing lines Patch % Lines
...s/js/components/RoomTabHistoryAttendanceButton.vue 11.11% 16 Missing ⚠️
...es/js/components/RoomTabHistoryStatisticButton.vue 16.66% 10 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1b6e457) and HEAD (89eb069). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (1b6e457) HEAD (89eb069)
6 4
Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #1600       +/-   ##
==============================================
- Coverage      80.85%   62.77%   -18.08%     
==============================================
  Files            359      157      -202     
  Lines           9141     4559     -4582     
  Branches         845      853        +8     
==============================================
- Hits            7391     2862     -4529     
+ Misses          1750     1697       -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

cypress bot commented Nov 21, 2024

PILOS    Run #1143

Run Properties:  status check failed Failed #1143  •  git commit 89eb069b9f: Improve error handling in room stats and attendance
Project PILOS
Branch Review 1535-improve-error-handling-in-room-history-components
Run status status check failed Failed #1143
Run duration 12m 53s
Commit git commit 89eb069b9f: Improve error handling in room stats and attendance
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 234
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/Frontend/e2e/RoomsViewHistoryMeetingActions.cy.js • 2 failed tests • Frontend tests

View Output

Test Artifacts
Rooms view history meeting actions > show stats Test Replay Screenshots
Rooms view history meeting actions > show attendance Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling in room history components
1 participant