Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Admin-UI management bugs #1588

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Conversation

SamuelWei
Copy link
Collaborator

Fixes #

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

Other information

@SamuelWei SamuelWei marked this pull request as draft November 19, 2024 16:47
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (3a7fbc6) to head (fa6a61c).
Report is 102 commits behind head on develop.

Files with missing lines Patch % Lines
resources/js/policies/UserPolicy.js 50.00% 1 Missing ⚠️
resources/js/views/AdminUsersIndex.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1588      +/-   ##
=============================================
+ Coverage      75.22%   81.05%   +5.83%     
- Complexity      1322     1340      +18     
=============================================
  Files            358      361       +3     
  Lines           9139     9223      +84     
  Branches         845      851       +6     
=============================================
+ Hits            6875     7476     +601     
+ Misses          2264     1747     -517     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Nov 19, 2024

PILOS    Run #1444

Run Properties:  status check passed Passed #1444  •  git commit fa6a61cafb: Fix Admin-UI management bugs
Project PILOS
Branch Review fix-admin-ui-user-management
Run status status check passed Passed #1444
Run duration 04m 50s
Commit git commit fa6a61cafb: Fix Admin-UI management bugs
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 237
View all changes introduced in this branch ↗︎

@SamuelWei SamuelWei changed the title Fix Admin-UI user management bugs Fix Admin-UI management bugs Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants