Use "native-picture-in-picture" presentation mode instead of using native element #472
+9
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new "native-picture-in-picture" presentation mode is not yet released but in the mean time this code can already be reviewed. |
wvanhaevre
approved these changes
Jan 8, 2025
tvanlaerhoven
force-pushed
the
feature/use-native-picture-in-picture
branch
from
5842ea9 to
38a75e8
Compare
tjtheo
approved these changes
Jan 14, 2025
tvanlaerhoven
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the "Presentation" API of THEOplayer to enter "native-picture-in-picture" instead of using the native video element.