Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/ios presentation mode leak #469

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Bugfix/ios presentation mode leak #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f72c658
Don't keep strong reference to targetViews
wvanhaevre Dec 18, 2024
8c87a77
Add changelog
wvanhaevre Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.1.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Fixed

- Fixed a memory leak on iOS, where the presentationModeManager was holding a strong reference to the fullscreen's target and return views

## [8.11.1] - 24-12-18

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions ios/presentationMode/THEOplayerRCTPresentationModeManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ public class THEOplayerRCTPresentationModeManager {
private var presentationMode: THEOplayerSDK.PresentationMode = .inline
private var rnInlineMode: THEOplayerSDK.PresentationMode = .inline // while native player is inline, RN player can be inline or fullsceen

private var containerView: UIView? // view containing the playerView and it's siblings (e.g. UI)
private var inlineParentView: UIView? // target view for inline representation
private weak var containerView: UIView? // view containing the playerView and it's siblings (e.g. UI)
private weak var inlineParentView: UIView? // target view for inline representation

// MARK: Events
var onNativePresentationModeChange: RCTDirectEventBlock?
Expand Down
Loading