Feature/media3 #447
Merged
Feature/media3 #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvanhaevre
approved these changes
Nov 24, 2024
tvanlaerhoven
force-pushed
the
feature/media3
branch
from
75912dc to
afeef12
Compare
wvanhaevre
approved these changes
Nov 28, 2024
tvanlaerhoven
force-pushed
the
feature/media3
branch
from
afeef12 to
c19e0c2
Compare
tvanlaerhoven
force-pushed
the
feature/media3
branch
from
c19e0c2 to
5d201ba
Compare
| playerView.player.addIntegration(media3Integration) | ||
| } | ||
| } catch (e: Exception) { | ||
| Log.w(TAG, "Failed to configure Cast integration ${e.message}") |
There was a problem hiding this comment.
This should probably log something like "Failed to configure Media3 integration ${e.message}" instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the experimental media3 pipeline on Android.