Feature/ Android: implement a special event for early transitioning to PiP (on animation start) #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvanlaerhoven
force-pushed
the
Android-implement-transitioning-to-PiP
branch
from
bfd5b54 to
edcbf41
Compare
|
Looking good, thanks @kot331107 |
tvanlaerhoven
force-pushed
the
Android-implement-transitioning-to-PiP
branch
from
edcbf41 to
ed681ae
Compare
tvanlaerhoven
force-pushed
the
Android-implement-transitioning-to-PiP
branch
from
ed681ae to
eabf60e
Compare
tvanlaerhoven
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implementation for https://developer.android.com/reference/android/app/PictureInPictureUiState#isTransitioningToPip() to set the PiP states a bit earlier on Android. Impacts only Android 15+ devices.
Test-Plan:
Repeat the same on API 34 (Android 14) to be sure nothing has been broken.