Enable e2e pipeline for newArch

THEOplayer · Nov 21, 2024 · e0dd2a1 · e0dd2a1
1 parent dfbf389
commit e0dd2a1
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/.github/workflows/pr_android.yml b/.github/workflows/pr_android.yml
@@ -17,6 +17,7 @@ jobs:
     strategy:
       matrix:
         api-level: [ 34 ]
+        newArchEnabled: [ false, true ]
     name: Build for API Level ${{ matrix.api-level }}
     steps:
       - name: Checkout repository
@@ -77,6 +78,13 @@ jobs:
           disable-animations: true
           script: echo "Generated AVD snapshot for caching."
 
+      - name: Modify gradle.properties for newArchEnabled
+        working-directory: e2e/android
+        run: |
+          # Modify or add the newArchEnabled property in gradle.properties
+          echo "newArchEnabled=${{ matrix.newArchEnabled }}" >> ./gradle.properties
+          cat ./gradle.properties
+
       - name: Run e2e tests
         uses: reactivecircus/android-emulator-runner@v2
         with:

diff --git a/.github/workflows/pr_ios.yml b/.github/workflows/pr_ios.yml
@@ -13,9 +13,11 @@ on:
 
 jobs:
   build:
+    runs-on: macos-latest
     strategy:
       matrix:
         xcode_version: [ '15.4.0' ]
+        newArchEnabled: [ 0, 1 ]
         platform: [iOS, tvOS]
     runs-on: macos-latest
     name: Build for ${{ matrix.platform }} using XCode version ${{ matrix.xcode_version }}
@@ -34,11 +36,19 @@ jobs:
           node-version: '18'
           cache: 'npm'
 
+      - name: Cache Ruby Gems
+        uses: actions/cache@v4
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-gems-
+
       - name: Cache CocoaPods
         uses: actions/cache@v4
         with:
           path: e2e/ios/Pods
-          key: pods-${{ runner.os }}-${{ hashFiles('Podfile.lock') }}
+          key: pods-${{ runner.os }}-${{ hashFiles('Podfile.lock') }}-${{ matrix.newArchEnabled }}
           restore-keys: |
             pods-${{ runner.os }}-
 
@@ -53,10 +63,13 @@ jobs:
           cd e2e
           npm ci
 
+      - name: Install Ruby dependencies
+        run: bundle install
+
       - name: Run pod install & update dependencies
         working-directory: e2e/ios
         run: |
-          pod update
+          RCT_NEW_ARCH_ENABLED=${{ matrix.newArchEnabled }} bundle exec pod update
 
       - name: Start iOS simulator
         uses: futureware-tech/simulator-action@v4
@@ -71,4 +84,5 @@ jobs:
 
       - name: Summarize results
         working-directory: e2e
+        if: always()
         run: cat cavy_results.md >> $GITHUB_STEP_SUMMARY