Merge pull request #469 from THEOplayer/bugfix/ios-presentationMode-leak

Bugfix/ios presentation mode leak
THEOplayer · Dec 23, 2024 · d023644 · d023644
2 parents 8e96427 + 8c87a77
commit d023644
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.1.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Fixed
+
+- Fixed a memory leak on iOS, where the presentationModeManager was holding a strong reference to the fullscreen's target and return views
+
 ## [8.11.1] - 24-12-18
 
 ### Fixed

diff --git a/ios/presentationMode/THEOplayerRCTPresentationModeManager.swift b/ios/presentationMode/THEOplayerRCTPresentationModeManager.swift
@@ -12,8 +12,8 @@ public class THEOplayerRCTPresentationModeManager {
     private var presentationMode: THEOplayerSDK.PresentationMode = .inline
     private var rnInlineMode: THEOplayerSDK.PresentationMode = .inline // while native player is inline, RN player can be inline or fullsceen
 
-    private var containerView: UIView?                  // view containing the playerView and it's siblings (e.g. UI)
-    private var inlineParentView: UIView?               // target view for inline representation
+    private weak var containerView: UIView?                  // view containing the playerView and it's siblings (e.g. UI)
+    private weak var inlineParentView: UIView?               // target view for inline representation
 
     // MARK: Events
     var onNativePresentationModeChange: RCTDirectEventBlock?