Enable e2e pipeline for newArch

THEOplayer · Nov 19, 2024 · 1a48d37 · 1a48d37
1 parent ce1b9ca
commit 1a48d37
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 5 deletions.
diff --git a/.github/workflows/pr_android.yml b/.github/workflows/pr_android.yml
@@ -2,14 +2,15 @@ name: Build Android on PRs
 on:
   workflow_dispatch:
   pull_request:
-    types: [opened, reopened, synchronize]
+    types: [ opened, reopened, synchronize ]
 
 jobs:
   build:
     runs-on: ubuntu-latest
     strategy:
       matrix:
         api-level: [ 34 ]
+        newArchEnabled: [ false, true ]
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -69,6 +70,13 @@ jobs:
           disable-animations: true
           script: echo "Generated AVD snapshot for caching."
 
+      - name: Modify gradle.properties for newArchEnabled
+        working-directory: e2e/android
+        run: |
+          # Modify or add the newArchEnabled property in gradle.properties
+          echo "newArchEnabled=${{ matrix.newArchEnabled }}" >> ./gradle.properties
+          cat ./gradle.properties
+
       - name: Run e2e tests
         uses: reactivecircus/android-emulator-runner@v2
         with:

diff --git a/.github/workflows/pr_ios.yml b/.github/workflows/pr_ios.yml
@@ -2,14 +2,15 @@ name: Build iOS on PRs
 on:
   workflow_dispatch:
   pull_request:
-    types: [opened, reopened, synchronize]
+    types: [ opened, reopened, synchronize ]
 
 jobs:
   build:
+    runs-on: macos-latest
     strategy:
       matrix:
         xcode_version: [ '15.4.0' ]
-    runs-on: macos-latest
+        newArchEnabled: [ 0, 1 ]
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -25,11 +26,19 @@ jobs:
           node-version: '18'
           cache: 'npm'
 
+      - name: Cache Ruby Gems
+        uses: actions/cache@v4
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-gems-
+
       - name: Cache CocoaPods
         uses: actions/cache@v4
         with:
           path: e2e/ios/Pods
-          key: pods-${{ runner.os }}-${{ hashFiles('Podfile.lock') }}
+          key: pods-${{ runner.os }}-${{ hashFiles('Podfile.lock') }}-${{ matrix.newArchEnabled }}
           restore-keys: |
             pods-${{ runner.os }}-
 
@@ -44,10 +53,13 @@ jobs:
           cd e2e
           npm ci
 
+      - name: Install Ruby dependencies
+        run: bundle install
+
       - name: Run pod install & update dependencies
         working-directory: e2e/ios
         run: |
-          pod update
+          RCT_NEW_ARCH_ENABLED=${{ matrix.newArchEnabled }} bundle exec pod update
 
       - name: Start iOS simulator
         uses: futureware-tech/simulator-action@v4
@@ -61,4 +73,5 @@ jobs:
 
       - name: Summarize results
         working-directory: e2e
+        if: always()
         run: cat cavy_results.md >> $GITHUB_STEP_SUMMARY