Fix Player.cast
not available before first source change
#49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #34, we added some logic to handle the case where the Chromecast integration is attached after we construct a
Player
instance. However, this only checks if the integration is attached when the player's source changed. If you tried to useplayer.cast
before the first source is set on the player, it would always returnnull
.Fix it by trying to update
player.cast
on every access. In the future, we should have the THEOplayer Android SDK handle this better, for exampletheoplayerView.cast
could return dummy values (instead ofnull
) if the Chromecast integration is not attached.Fixes #47