Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Player.cast not available before first source change #49

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

MattiasBuelens
Copy link
Collaborator

In #34, we added some logic to handle the case where the Chromecast integration is attached after we construct a Player instance. However, this only checks if the integration is attached when the player's source changed. If you tried to use player.cast before the first source is set on the player, it would always return null.

Fix it by trying to update player.cast on every access. In the future, we should have the THEOplayer Android SDK handle this better, for example theoplayerView.cast could return dummy values (instead of null) if the Chromecast integration is not attached.

Fixes #47

@MattiasBuelens MattiasBuelens added the bug Something isn't working label Oct 11, 2024
@MattiasBuelens MattiasBuelens merged commit 2da0fd0 into develop Oct 15, 2024
1 check passed
@MattiasBuelens MattiasBuelens deleted the fix-player-cast-without-source branch October 15, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chrome cast compatibility with core sdk
1 participant