Update FullscreenHandler.kt #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make full screen handler compatible with edge to edge
MattiasBuelens
approved these changes
Aug 28, 2024
| @@ -35,7 +35,6 @@ internal class FullscreenHandlerImpl(private val view: View) : FullscreenHandler | |||
| val window = activity.window | |||
|
|
|||
| // Hide system bars | |||
| WindowCompat.setDecorFitsSystemWindows(window, false) | |||
There was a problem hiding this comment.
Honestly, I don't remember where I got this code from. 😅
It looks like this guide is the best resource at the moment, and it doesn't mention setDecorFitsSystemWindows at all. So I suppose it's not needed. 👍
MattiasBuelens
force-pushed
the
full-screen-handler
branch
from
173a01d to
3bee8f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make fullScreen handler compatible with edge-to-edge.
Hello.
The current version of the full screen doesn't respect developer-selected edge-to-edge. If the developer enables the edge-to-edge feature, and then the end user goes to full screen and then returns, you force the system to ignore the edge-to-edge.
The before state is as follows:
before.mp4
The after is like this. There is no need to mention that it behaves correctly, whether the developer enables the edge-to-edge feature or not.
after.mov
Thank you.
@ceyhun-o @georgechoustoulakis @MattiasBuelens @tvanlaerhoven