Feature/theo 10603 sgai conviva #40
Conversation
| val adTechnology = | ||
| if (ad.integration == AdIntegrationKind.THEO_ADS) "Server Guided" else calculateAdTypeAsString( | ||
| ad | ||
| ) |
There was a problem hiding this comment.
Couldn't we put the "Server Guided" check into calculateAdTypeAsString?
There was a problem hiding this comment.
Indeed would be better, will update it
| "c3.ad.firstCreativeId" to validStringOrNA( | ||
| ad.wrapperCreativeIds.firstOrNull() ?: ad.creativeId | ||
| ), | ||
| "c3.ad.firstCreativeId" to "NA", |
There was a problem hiding this comment.
We are never sending the firstCreativeId now?
There was a problem hiding this comment.
We will for google IMA ad, otherwise it is "NA" indeed since I don't think this info is present in the base Ad event.
I split the previous collectAdMetadata function up into all the data we have on a base Ad object and the extra info we get from Google IMA.
So after collectAdMetadata we check if we have an IMA ad, if so we call updateAdMetadataForGoogleIma and add the extra metadata.
If some of the information is present in the normal Ad object after all I can update it.
Jeroen-Veltmans
force-pushed
the
feature/THEO-10603-sgai-conviva
branch
from
162d628 to
851e9fc
Compare
We don't know if the ads in an ad break are linear so only use adBegin event
Update calculateAdType to setup THEOads for later, aligns with web connector
Pass Server Guided ad technology
Also updated the connector to take the regul Ad events into account instead of only the Google Ima Ad events