feat: insert role manager into organizations #1429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ori-dapp into e2e-test-dao-creation-gno
…dev/mikaelvallenet/feat/register-dao-to-profile-realm
…into dev/mikaelvallenet/feat/gno-display-dao-members
We had a lot of problems with long-running branches and decided to avoid them so I would advise against that and instead to try make atomic PRs against |
|
maybe we could start by a refactor of the org creation flow and introduce a new flow that doesn't affect the existing one.
this way you can iterate on it on main, wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to insert the role manager into our DAO ontracts and UI.
This is a big PR, so I've decided to create an “organizations-role-manager” branch, which will receive atomic PRs from now on to gradually reach a usable stage, at which point it will merge with main.