Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(feed): Parse MusicAudio and Video posts metadata on Map Feed #1400

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix(feed): Parse MusicAudio and Video posts metadata on Map Feed #1400

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f2115fb
fix: made keys for social post optional while parsing except title
sujal-into Nov 20, 2024
3a16113
fix: added a function to parse different social feed categories metadata
sujal-into Nov 21, 2024
ece2bac
fix: used switch case to parse different social feed metadata
sujal-into Nov 21, 2024
7a18deb
fix: Changed to feedArticle metadata for article type
sujal-into Nov 22, 2024
ac6d3b5
default social media parse to common metadata
sujal-into Nov 22, 2024
8a0ebc6
fix: feed post metadata check for video and article
sujal-into Nov 22, 2024
0b9046c
fix: removed post metdata option from video and article type
sujal-into Nov 25, 2024
1ac1350
Merge branch 'main' into bugfix/video-audio-map
WaDadidou Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/components/socialFeed/Map/Map.web.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,11 @@ export const Map: FC<MapProps> = ({
const markers: MarkerPopup[] = useMemo(() => {
if (!posts) return [];
const results: MarkerPopup[] = [];
posts.forEach((post, index) => {
posts.forEach((post) => {
const metadata = zodTryParseJSON(
ZodSocialFeedPostMetadata,
ZodSocialFeedPostMetadata.partial().merge(
ZodSocialFeedPostMetadata.pick({ title: true }),
Copy link
Collaborator

@WaDadidou WaDadidou Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to modify the Zod type to try parse.
Yes, ZodSocialFeedPostMetadata shape can be wrong, but we have made other shapes for other posts categories. So we need to handle them.

Reformulation: The issue is due to the fact we have 4 differents types for the fetched posts.
Here we only try to parse ZodSocialFeedPostMetadata. So, the tracks and videos posts validation fails.

The result here has no success: https://github.com/TERITORI/teritori-dapp/blob/bugfix/video-audio-map/packages/utils/sanitize.ts#L22
If you console.log the result, you will see what's wrong to validate ZodSocialFeedPostMetadata

To avoid that, because the map gathers all posts categories, we must handle these Zod types. Here is my suggestion:

const videoPostMetadata = zodTryParseJSON(
  ZodSocialFeedVideoMetadata,
  post.metadata,
);
const trackMetadata = zodTryParseJSON(
  ZodSocialFeedTrackMetadata,
  post.metadata,
);
const articleMetadata = zodTryParseJSON(
  ZodSocialFeedArticleMetadata,
  post.metadata,
);
const postMetadata = zodTryParseJSON(
  ZodSocialFeedPostMetadata,
  post.metadata,
);
const metadataToUse = videoPostMetadata || trackMetadata || articleMetadata || postMetadata;

We need a refacto about it. Either unify all types in one, either add an utilitary function to handle (try parse) these differents zod types

Copy link
Collaborator

@n0izn0iz n0izn0iz Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no there is the zodSocialFeedCommonMetadata schema when you need to only parse the title

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a fix for this discussion in this commit: 3a16113

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no there is the zodSocialFeedCommonMetadata schema when you need to only parse the title

In this case, there are other things that i need to parse also based on the category type, so I have created a util function to handle those cases.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can switch on the post type to do the proper parsing in each case, the whole point of using zod is to have type safety, using a z.ZodTypeAny entirely defeat this purpose

Copy link
Collaborator Author

@sujal-into sujal-into Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used switch and removed the ZodTypeAny : ece2bac

),
post.metadata,
);
if (!metadata?.location) return;
Expand Down
Loading