Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : 내 스크립트 페이지 추가 #17

Merged
merged 6 commits into from
Jul 13, 2024
Merged

Conversation

koeunbeee
Copy link
Contributor

요약 (Summary)

내 스크립트 페이지 추가

변경 사항 (Changes)

내 스크립트 임시데이터 추가
스크립트카드 컴포넌트, 포인트컬러 버튼 컴포넌트 추가
css 없는 컬러 추가

리뷰 요구사항

컬러에 없는 색상 추가했는데 이렇게 해도 되나용?

@koeunbeee koeunbeee requested a review from Nangniya July 13, 2024 01:32
@koeunbeee koeunbeee changed the base branch from main to develop July 13, 2024 01:32
@Nangniya
Copy link
Contributor

image
여기 변수 선언해놓고 안써서 빌드 안되고있습니다!

그리고 색상같은거는 일단 디자인 시스템에 있는거만 변수로 추가했는데
다 변수로 추가할 필요는 없고 재사용 될 것 같은 색은 변수로 추가해주시고 아니라면 직접 CSS 적용해주시면 됩니다!

Copy link

Visit the preview URL for this PR (updated for commit ad234ec):

https://hearus-668d7--pr17-feat-my-script-i18kfbzk.web.app

(expires Sat, 20 Jul 2024 01:57:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf5e680be215afe513793a0ffcca015694c306c5

@Nangniya Nangniya merged commit fe59782 into develop Jul 13, 2024
2 checks passed
@koeunbeee koeunbeee deleted the feat/my-script branch July 13, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants