Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 디자인 시스템 수정 #10

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Fix: 디자인 시스템 수정 #10

merged 3 commits into from
Jul 4, 2024

Conversation

Nangniya
Copy link
Contributor

@Nangniya Nangniya commented Jul 4, 2024

요약 (Summary)

디자인 시스템 수정

변경 사항 (Changes)

  • scr/styles/variables/fonts.scss 폰트 변수명들 수정 및 추가

리뷰 요구사항

@mixin Semibold-Title-32 {
  font-family: 'Pretendard-SemiBold';
  font-size: 32pt;
  letter-spacing: -0.025em;
}

@mixin Medium-Title-24 {
  // 임의로 추가
  font-family: 'Pretendard-Medium';
  font-size: 24pt;
  letter-spacing: -0.025em;
}

@mixin SemiBold-Body-18 {
  font-family: 'Pretendard-SemiBold';
  font-size: 18pt;
  letter-spacing: -0.025em;
}

@mixin Medium-Body-18 {
  font-family: 'Pretendard-Medium';
  font-size: 18pt;
  letter-spacing: -0.025em;
}

@mixin Regular-Body-18 {
  font-family: 'Pretendard-Regular';
  font-size: 18pt;
  letter-spacing: -0.025em;
}

@mixin SemiBold-Body-16 {
  font-family: 'Pretendard-SemiBold';
  font-size: 16pt;
  letter-spacing: -0.025em;
}

@mixin Medium-Body-16 {
  font-family: 'Pretendard-Medium';
  font-size: 16pt;
  letter-spacing: -0.025em;
}

@mixin Regular-Body-16 {
  font-family: 'Pretendard-Regular';
  font-size: 16pt;
  letter-spacing: -0.025em;
}

@mixin SemiBold-Sub-14 {
  font-family: 'Pretendard-SemiBold';
  font-size: 14pt;
  letter-spacing: -0.025em;
}

@mixin Medium-Sub-14 {
  font-family: 'Pretendard-Medium';
  font-size: 14pt;
  letter-spacing: -0.025em;
}

@mixin Regular-Sub-14 {
  font-family: 'Pretendard-Regular';
  font-size: 14pt;
  letter-spacing: -0.025em;
}

해당 변수명들을 import해서 이런식으로 쓰시면 됩니다!

@import '../../../../styles/variables/colors.scss';
@import '../../../../styles/variables/fonts.scss';

.className {
  @include Medium-Body-16; //폰트
  color: $light-gray_81; //색상
}

확인 방법 (선택)

image

디자이너분께 요청해서 피그마에도 반영되었습니다!
피그마에서 클릭해서 폰트명 및 사이즈 확인하고 맞는 변수 사용하면 됩니다.

Copy link

github-actions bot commented Jul 4, 2024

Visit the preview URL for this PR (updated for commit 5227b81):

https://hearus-668d7--pr10-fix-design-system-ltcl448d.web.app

(expires Thu, 11 Jul 2024 10:20:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf5e680be215afe513793a0ffcca015694c306c5

@Nangniya Nangniya merged commit 5d845f4 into develop Jul 4, 2024
2 checks passed
@Nangniya Nangniya deleted the fix/design-system branch July 4, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant