Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 검색창 애니메이션 적용 #9
base: develop
Are you sure you want to change the base?
feat: 검색창 애니메이션 적용 #9
Changes from 10 commits
7005b34
8a14aad
ecf1c5e
7cb2963
161d6eb
324065a
14d8f9d
5e77625
8922081
6747370
228549f
57bec5a
fd27d65
585322a
931c756
a28220e
cb255ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check warning on line 1 in src/features/search/ui/components/ModalSearch.tsx
GitHub Actions / lint 체크
Check warning on line 1 in src/features/search/ui/components/ModalSearch.tsx
GitHub Actions / lint 체크
Check warning on line 11 in src/features/search/ui/components/ModalSearch.tsx
GitHub Actions / lint 체크
Check warning on line 11 in src/features/search/ui/components/ModalSearch.tsx
GitHub Actions / lint 체크
Check warning on line 11 in src/features/search/ui/components/ModalSearch.tsx
GitHub Actions / lint 체크
Check warning on line 11 in src/features/search/ui/components/ModalSearch.tsx
GitHub Actions / lint 체크
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
results 는 input 만의 역할에 벗어난 데이터,
query는 input element의 일반적인 역할의 이름인 value 로
setQuery는 input 을 초기화 하는 용도로만 사용되는데 이걸 덜어낼 방향을 생각해보시는 것도.. 굳이 필요한 props 인가? 구현(동작)을 위해 껴넣어진 props 인가?
onSubmit 은 input레벨이 아니라 상위에서 처리해야 할 관심인 것 같아요
인풋의 역할은 사용자의 입력을 받아, 그 값을 상태로 관리해주고, 추가적으로 인풋이 오버레이 형태니 그것의 열고 닫힘을 관리해주는 것까지로 한정지을 수도 있겠네요
검색어를 submit 하고 결과를 찾아 result 를 보여주는 건 input 의 역할에서 벗어난 듯해요
이것을 생각하면서 props 디자인을 해보는 것도 괜찮을듯함다
Check warning on line 56 in src/features/search/ui/components/SearchInput.tsx
GitHub Actions / lint 체크
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
찾는 Input UI 와 Input 에 따른 결과 Result UI 는 Input 내에 있기보단 동일 레벨에 있어야 할 것 같아요
Input UI 가 결과 UI 를 알고 있는 구조가 자연스럽진 않아서요
Result UI 의 변경이 Input 에 영향을 끼치게 됨
to-be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 파일 내부에 만들고 재사용하는 방법은.. 선택