Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

feat: add OrderInstructions #99

Merged
merged 5 commits into from
Aug 1, 2024
Merged

feat: add OrderInstructions #99

merged 5 commits into from
Aug 1, 2024

Conversation

ethanwlee
Copy link
Contributor

per the tbdex spec, this pr adds the OrderInstructions message and removes the PaymentInstruction object from the Quote message

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.96491% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.25%. Comparing base (b28cbe5) to head (bccfe8e).

Files Patch % Lines
Sources/tbDEX/Protocol/DevTools.swift 74.07% 7 Missing ⚠️
...es/tbDEX/Protocol/Models/Messages/AnyMessage.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   93.65%   93.25%   -0.40%     
==========================================
  Files          32       34       +2     
  Lines        1245     1290      +45     
==========================================
+ Hits         1166     1203      +37     
- Misses         79       87       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ethanwlee ethanwlee merged commit 1234102 into main Aug 1, 2024
1 check passed
@ethanwlee ethanwlee deleted the add-orderinstructions branch August 1, 2024 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants