-
Notifications
You must be signed in to change notification settings - Fork 396
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix
ObjectDisposedException
when loading non-disc rom into Libretro
fixes d9da3cf
- Loading branch information
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -835,7 +835,7 @@ public bool LoadRom(string path, CoreComm nextComm, string launchLibretroCore, s | |
var ext = file.Extension; | ||
var gi = Disc.IsValidExtension(ext) | ||
? MakeGameFromDisc(InstantiateDiscFor(path), ext: ext, name: Path.GetFileNameWithoutExtension(file.Name)) | ||
: new RomGame(file).GameInfo; | ||
: new RomGame(new(file.CanonicalFullPath)).GameInfo; // need to re-open??? | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
YoshiRulz
Author
Member
|
||
Game.Name = $"{gi.Name} [{Game.Name/* core name */}]"; | ||
} | ||
} | ||
|
I assume Dispose() call is happening with ReadAllBytes()
BizHawk/src/BizHawk.Common/HawkFile/HawkFile.cs
Line 277 in 4aa3342