Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
인증부분 화면 구성을 진행합니다. #22
base: develop
Are you sure you want to change the base?
인증부분 화면 구성을 진행합니다. #22
Changes from 5 commits
8b03b9c
c476413
2697728
66d3662
a3a7c21
c388d0a
4fcc1d7
4d86b2a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이건 그냥 궁금해서 여쭤보는 건데, feature 하위 폴더명을 CamelCase가 아닌 dot notation으로 표기하신 이유가 궁금합니다. 이렇게 하는게 일반적인 컨벤션인가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sera2002 오... 넵넵 좋은 질문입니다. [일반적인 컨벤션] 은 아니고... 제가 최근에 진행한 프로젝트가 이렇게 했다 보니 무의식중에 한 것 같네요 😓
음... 글쎄요...ㅋㅋㅋ 이유는 없습니다만 세라님 말씀처럼 하나로 통일하는 것이 좋을 것 같아요 혹시 세라님 작업분 중 feature 안에 또 저렇게 이중 폴더가 들어가는 부분이 있나용?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://askubuntu.com/questions/413150/is-it-bad-practice-for-folder-name-to-contain-a-dot-how-about-a-file-name-w
음.. 이런 배경도 있을 수 있겠군요.. CLI 상에서 조작하기 어렵다는 점도? 있을 것 같고 한데 뭔가 조금 '이 폴더는 일반적인 폴더보다는 조금 다른 폴더이다' 라는 느낌을 강조하고 싶었던 것 같습니다. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 저는 feature 내에 위치한 이중 폴더 이름을 CamelCase로 해놨었는데, dot notation으로 통일하는 것도 뭔가 보기에도 깔끔하고 괜찮을 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 넵 근데 뭔가 컨벤션(?) 에 예외를 두는 것 같아서 그냥 전부 camelCase 로 통일하는 것은 조금 그럴까용? 뭐가 좋을지 모르겠네유 @sera2002 @hoon5083
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저는 camelCase와 dot notation의 용도가 다른거 같긴 합니다. dot notation으로 하면 좀더 계층적임을 잘 보여주지 않나 싶어요
camelCase는 단순히 여러단어를 구분하기 위한 용도 같구요