Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Access Token이 Bearer null 인 경우 Optional이 작동하지 않음 #128

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[FIX] Access Token이 Bearer null 인 경우 Optional이 작동하지 않음 #128

merged 2 commits into from
Nov 25, 2024

Conversation

2tle
Copy link
Contributor

@2tle 2tle commented Nov 25, 2024

작성자: @2tle

close #127

체크 리스트

  • 적절한 제목으로 수정했나요?
  • 상단에 이슈 번호를 기입했나요?
  • Target Branch를 올바르게 설정했나요?
  • Reviewers/Assignees/Labels을 알맞게 설정했나요?

작업 내역

  • accessToken 추출하는 위치 변경
  • Optional 검사시, 추출한 access token이 문자열 null 인지 검사하는 로직 추가

비고

  • 프론트엔드에서 로그인 안한 상태에서는 access token이 문자열 null로 들어옵니다. 이 문제를 해결하기 위해 null 문자열 검증 로직을 추가했는데, 혹시 더 좋은 의견 있으시면 아무나 댓글 달아주시면 감사하겠습니다

@2tle 2tle added 🐞 Bug 버그 수정 🎯 API API 개발 관련 auth domain labels Nov 25, 2024
@2tle 2tle requested review from jcy0308 and yesjuhee November 25, 2024 01:52
@2tle 2tle self-assigned this Nov 25, 2024
yesjuhee
yesjuhee reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@yesjuhee yesjuhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이런 오류는 예상 못했네요
감사합니다 👍

src/main/java/com/scg/stop/auth/config/AuthUserArgumentResolver.java Outdated Show resolved Hide resolved
yesjuhee
yesjuhee approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@yesjuhee yesjuhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM입니당

@2tle 2tle merged commit 0729132 into develop Nov 25, 2024
1 check passed
@2tle 2tle deleted the fix/127-auth-access-token branch November 25, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesjuhee yesjuhee yesjuhee approved these changes

@jcy0308 jcy0308 Awaiting requested review from jcy0308

Assignees

@2tle 2tle

Labels
🎯 API API 개발 관련 auth domain 🐞 Bug 버그 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 [BUG] Access Token이 Bearer null 인 경우 Optional이 작동하지 않음
2 participants
@2tle @yesjuhee