Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] JobInfo 웹사이트, logo 이미지 fetching 수정 #120

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

shj1081
Copy link
Contributor

@shj1081 shj1081 commented Nov 21, 2024

작성자: @shj1081

close #119

체크 리스트

  • 적절한 제목으로 수정했나요?
  • 상단에 이슈 번호를 기입했나요?
  • Target Branch를 올바르게 설정했나요?
  • Reviewers/Assignees/Labels을 알맞게 설정했나요?

작업 내역

  • logo 이미지의 경우 attach file 의 type이 external type 또한 존재하여 이를 handling 하는 logic 추가 @chqkq
  • website link의 json 경로가 잘못 지정되어 있어 불러오지 못하는 것 수정

비고

{
    "totalElements": 3,
    "totalPages": 1,
    "first": true,
    "last": true,
    "size": 10,
    "content": [
        {
            "company": "job info 1",
            "jobTypes": [
                "type1"
            ],
            "region": "region1",
            "position": "position1",
            "logo": "https://prod-files-secure.s3.us-west-2.amazonaws.com/06287c4d-6784-4479-a83f-adb4b3b1a56d/14b64322-513d-46f9-8c41-d021259c4020/8b6d3575-da92-41d4-bc67-04d5e4acfa23_%281%29.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=AKIAT73L2G45FSPPWI6X%2F20241121%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20241121T114823Z&X-Amz-Expires=3600&X-Amz-Signature=4be342e6e45cbe5a3d7928fd08fcae4fdbadf2e5402ffbcd0943e9d32229483f&X-Amz-SignedHeaders=host&x-id=GetObject",
            "salary": "1000만원",
            "website": "testlink",
            "state": [
                "open"
            ],
            "hiringTime": "시점1",
            "object": "page",
            "id": "00c62661-99fd-4a40-b5b2-273f5dfa65c6",
            "url": "https://www.notion.so/job-info-1-00c6266199fd4a40b5b2273f5dfa65c6"
        },
        {
            "company": "job info 2",
            "jobTypes": [
                "type1",
                "type2"
            ],
            "region": "region2",
            "position": "position2",
            "logo": "https://blog.kakaocdn.net/dn/HDY7T/btrY2our4Rw/Fw6bz0QroBUp1YxglkkwEK/img.webp",
            "salary": "2000만원",
            "website": "testlink",
            "state": [
                "open"
            ],
            "hiringTime": "시점2",
            "object": "page",
            "id": "9efebd14-528a-48fc-ad15-89b5b33a4aeb",
            "url": "https://www.notion.so/job-info-2-9efebd14528a48fcad1589b5b33a4aeb"
        },
        {
            "company": "job info 3",
            "jobTypes": [
                "type3"
            ],
            "region": "region4",
            "position": "position3",
            "logo": "https://prod-files-secure.s3.us-west-2.amazonaws.com/06287c4d-6784-4479-a83f-adb4b3b1a56d/7bb1e43e-5a73-4cff-ace8-4c1efd889301/icons8-aws-240.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=AKIAT73L2G45FSPPWI6X%2F20241121%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20241121T114823Z&X-Amz-Expires=3600&X-Amz-Signature=202f4a8a3c65a5a147a27ccab7116dabecf18f5f917cba40c559dd5cab3c578f&X-Amz-SignedHeaders=host&x-id=GetObject",
            "salary": "3000만원",
            "website": "testlink",
            "state": [
                "close"
            ],
            "hiringTime": "시점3",
            "object": "page",
            "id": "d3cea5b7-9edc-4e24-9dee-ead39d747272",
            "url": "https://www.notion.so/job-info-3-d3cea5b79edc4e249deeead39d747272"
        }
    ],
    "number": 0,
    "sort": {
        "empty": true,
        "sorted": false,
        "unsorted": true
    },
    "numberOfElements": 3,
    "pageable": {
        "pageNumber": 0,
        "pageSize": 10,
        "sort": {
            "empty": true,
            "sorted": false,
            "unsorted": true
        },
        "offset": 0,
        "paged": true,
        "unpaged": false
    },
    "empty": false
}

@shj1081 shj1081 added 🐞 Bug 버그 수정 🎯 API API 개발 관련 Notion Domain labels Nov 21, 2024
@shj1081 shj1081 self-assigned this Nov 21, 2024
@shj1081 shj1081 changed the title [fix] JobInfo 웹사이트 / logo 이미지 fetching 수정 [FIX] JobInfo 웹사이트 / logo 이미지 fetching 수정 Nov 21, 2024
@shj1081 shj1081 changed the title [FIX] JobInfo 웹사이트 / logo 이미지 fetching 수정 [FIX] JobInfo 웹사이트, logo 이미지 fetching 수정 Nov 21, 2024
Copy link
Contributor

@yesjuhee yesjuhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 수고하셨습니다!

@shj1081 shj1081 merged commit 64cc291 into develop Nov 24, 2024
1 check passed
@shj1081 shj1081 deleted the fix/119-fetching-jobinfo branch November 24, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 API API 개발 관련 🐞 Bug 버그 수정 Notion Domain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 [BUG] JobInfo API logo, website property fetching
2 participants