Refactor existing codebase

Synzvato · Jun 29, 2018 · 29a6942 · 29a6942
1 parent 48a6614
commit 29a6942
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/core/constants.js b/core/constants.js
@@ -27,6 +27,8 @@ const Address = {
     'EXAMPLE': 'example.org',
     'HTTP': 'http:',
     'HTTPS': 'https:',
+    'RESOURCE_PATH': '/resources',
+    'ROOT_PATH': '/',
     'WWW_PREFIX': 'www.'
 };
 

diff --git a/core/file-guard.js b/core/file-guard.js
@@ -39,7 +39,7 @@ fileGuard._startListening = function () {
 
 fileGuard._verifyRequest = function (requestDetails) {
 
-    let redirectUrl = chrome.runtime.getURL('/');
+    let redirectUrl = chrome.runtime.getURL(Address.ROOT_PATH);
 
     if (!requestDetails.url.endsWith(fileGuard.secret)) {
         return {redirectUrl};
@@ -50,7 +50,7 @@ fileGuard._verifyRequest = function (requestDetails) {
  * Initializations
  */
 
-fileGuard.path = chrome.runtime.getURL('/resources');
+fileGuard.path = chrome.runtime.getURL(Address.RESOURCE_PATH);
 fileGuard.secret = '';
 
 if (fileGuard.path.startsWith(Address.CHROME_EXTENSION)) {

diff --git a/core/state-manager.js b/core/state-manager.js
@@ -123,7 +123,7 @@ stateManager._removeTab = function (tabIdentifier) {
 
 stateManager._updateTab = function (details) {
 
-    let tabDomain, domainIsWhitelisted, tabIdentifier, frameIdentifier;
+    let tabDomain, domainIsWhitelisted, frameIdentifier, tabIdentifier;
 
     tabDomain = helpers.extractDomainFromUrl(details.url);
     domainIsWhitelisted = stateManager._domainIsWhitelisted(tabDomain);