Revert "Move String backing storage to shared ptr" #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellar-aria
approved these changes
Jan 15, 2025
Merged
via the queue into
SynthstromAudible:community
with commit Jan 15, 2025
3facf8a
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3219
This reverts commit cb286e and 64ebcdc (bugfix for concatenation)
In discussion with @stellar-aria we'll move towards just using std string and a small object allocator to avoid the need for CoW strings in the first place - Rohan used them to avoid fragmentation but improvements to the allocation strategy since then likely make it unneeded if we just separate strings (or all small objects?) from the main external allocator