Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::string_view refactoring #3211

Open
wants to merge 7 commits into
base: community
Choose a base branch
from
Open

std::string_view refactoring #3211

wants to merge 7 commits into from

Conversation

stellar-aria
Copy link
Collaborator

  • refactors most uses of l10n to string_view
  • changes the inputs of display character strings
  • introduces util/string for creating strings that conform to the Deluge's requirements for formatting. Each one is guaranteed to be small-string-optimized (i.e. stack-only)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025 •
edited
Loading

Test Results

106 tests  ±0   106 ✅ ±0   1s ⏱️ ±0s
 16 suites ±0     0 💤 ±0 
 16 files   ±0     0 ❌ ±0 

Results for commit 675258c. ± Comparison against base commit e936bb8.

♻️ This comment has been updated with latest results.

@stellar-aria stellar-aria force-pushed the l10n-string-view branch 2 times, most recently from f6059cd to 219daa3 Compare January 4, 2025 15:07
@sapphire-arches
Copy link
Collaborator

Size delta report: https://gist.github.com/sapphire-arches/4fb3c23657e429bef548f65c6fbe8521

Overview:

 1425708	  34272	 448768	1908748	 1d200c	baseline
 1452412	  34392	 448968	1935772	 1d899c	stringview
  +26704	       	       	 +27024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellar-aria @sapphire-arches