Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 chore(ci): Upload entire report instead of individual traces #942

Merged
merged 1 commit into from
Oct 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ jobs:
run: pnpm run build

- name: Run E2E tests (headless)
run: pnpm run test:e2e:headless -- --output "test-results-headless"
run: pnpm run test:e2e:headless

- name: Archive Playwright traces
- name: Archive Playwright report
uses: actions/upload-artifact@v3
if: success() || failure()
with:
name: playwright-traces-headless
name: playwright-report-headless
path: |
wallets/metamask/test-results-headless/
wallets/metamask/playwright-report-headless/
if-no-files-found: error

test-e2e-headful:
Expand Down Expand Up @@ -76,13 +76,13 @@ jobs:

- name: Run E2E tests (headful)
run: |
xvfb-run pnpm run test:e2e:headful -- --output "test-results-headful"
xvfb-run pnpm run test:e2e:headful

- name: Archive Playwright traces
- name: Archive Playwright report
uses: actions/upload-artifact@v3
if: success() || failure()
with:
name: playwright-traces-headful
name: playwright-report-headful
path: |
wallets/metamask/test-results-headful/
wallets/metamask/playwright-report-headful/
if-no-files-found: error
4 changes: 3 additions & 1 deletion wallets/metamask/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ export default defineConfig({

// Concise 'dot' for CI, default 'html' when running locally.
// See https://playwright.dev/docs/test-reporters.
reporter: process.env.CI ? 'dot' : 'html',
reporter: process.env.CI
? [['html', { open: 'never', outputFolder: `playwright-report-${process.env.HEADLESS ? 'headless' : 'headful'}` }]]
: 'html',

// Shared settings for all the projects below.
// See https://playwright.dev/docs/api/class-testoptions.
Expand Down