Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add foundry integration #845
base: dev
Are you sure you want to change the base?
add foundry integration #845
Changes from all commits
745f381
5bc9a0e
bb58e37
cf16f49
ff68cfc
63fd826
da9df17
f29a5a2
62c2eda
49546fd
d316977
fc6a18c
e5dd29f
8528574
6de7729
0f62a11
53052ab
e6e2eb1
f3f630f
668caba
fe60bc8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing module level state like this is common in synpress and not a good practice in general imo. Instead state should be instanciated by user e.g.
synpressFoundry(options)
where on the implementation you can set state in the factory function or the class in case of doingnew SynpressFoundry(options)
. It's way more robust to later having more than one for example and leads to less problems long term. Easier to read the code and debug too imoThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should write new code in a .mjs file imo so converting it to TS later is easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you did the new AnvilSynpressUtil() pattern here the utility could give these to user so user could use them in their tests too
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.