✨ feat: New network and switch network Cypress APIs #1198
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matstyler
changed the title
matstyler
changed the title
matstyler
changed the title
| cy.get('#deployERC1155Button').click() | ||
|
|
||
| cy.confirmTransaction().then(() => { | ||
| cy.wait(5000) |
There was a problem hiding this comment.
@matstyler why wait? we have to avoid waits at all cost
There was a problem hiding this comment.
we do not have tools to avoid it at the moment, I will have to resolve it separately
There was a problem hiding this comment.
@matstyler from my understanding, this transaction has to be confirmed before we can execute next steps in this test.
I think we should add a new task for it => if specific flag is passed to confirmtransaction (waitfortx: true?), then it will automatically wait for tx to be confirmed before moving on.
| cy.get('#deployERC1155Button').click() | ||
|
|
||
| cy.confirmTransaction().then(() => { | ||
| cy.wait(5000) |
There was a problem hiding this comment.
@matstyler from my understanding, this transaction has to be confirmed before we can execute next steps in this test.
I think we should add a new task for it => if specific flag is passed to confirmtransaction (waitfortx: true?), then it will automatically wait for tx to be confirmed before moving on.
Motivation and context
New network and switch network APIs for Cypress.
Does it fix any issue?
https://linear.app/synpress/issue/SYN-129/new-network-approvals-approvenewnetworkspects
https://linear.app/synpress/issue/SYN-131/expand-cypress-api-to-add-approveswitchnetworkspects-test-cases
Quality checklist