Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/confirm signature and encrypt #1189

Merged
merged 22 commits into from
Jul 29, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: renamed configureBeforeSynpress.ts to configureSynpress.ts
matstyler committed Jul 14, 2024
commit ebc419d5440f803f3e7ec174c4ed6893cd2d4634
4 changes: 2 additions & 2 deletions examples/new-dawn/cypress.config.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { configureBeforeSynpress } from '@synthetixio/synpress/cypress'
import { configureSynpress } from '@synthetixio/synpress/cypress'
import { defineConfig } from 'cypress'

export default defineConfig({
@@ -9,7 +9,7 @@ export default defineConfig({
supportFile: 'test/cypress/support/e2e.{js,jsx,ts,tsx}',
testIsolation: false,
async setupNodeEvents(on, config) {
return configureBeforeSynpress(on, config)
return configureSynpress(on, config)
}
}
})
4 changes: 2 additions & 2 deletions wallets/ethereum-wallet-mock/cypress.config.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { defineConfig } from 'cypress'
import { configureBeforeSynpress } from './src/cypress'
import { configureSynpress } from './src/cypress'

export default defineConfig({
chromeWebSecurity: false,
@@ -10,7 +10,7 @@ export default defineConfig({
fixturesFolder: 'src/cypress/fixtures',
testIsolation: false,
async setupNodeEvents(on, config) {
return configureBeforeSynpress(on, config)
return configureSynpress(on, config)
}
}
})
2 changes: 1 addition & 1 deletion wallets/ethereum-wallet-mock/src/cypress/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export { default as configureBeforeSynpress } from './utils/configureBeforeSynpress'
export { default as configureSynpress } from './utils/configureSynpress'
export { default as EthereumWalletMock } from './EthereumWalletMock'
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ import { initEthereumWalletMock } from './initEthereumWalletMock'

let port: number

export default function configureBeforeSynpress(on: Cypress.PluginEvents, config: Cypress.PluginConfigOptions) {
export default function configureSynpress(on: Cypress.PluginEvents, config: Cypress.PluginConfigOptions) {
const browsers = config.browsers.filter((b) => b.name === 'chrome')
if (browsers.length === 0) {
throw new Error('No Chrome browser found in the configuration')
4 changes: 2 additions & 2 deletions wallets/metamask/cypress.config.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { defineConfig } from 'cypress'
import configureBeforeSynpress from './src/cypress/configureBeforeSynpress'
import configureSynpress from './src/cypress/configureSynpress'

export default defineConfig({
chromeWebSecurity: false,
@@ -9,7 +9,7 @@ export default defineConfig({
supportFile: 'src/cypress/support/e2e.{js,jsx,ts,tsx}',
testIsolation: false,
async setupNodeEvents(on, config) {
return configureBeforeSynpress(on, config)
return configureSynpress(on, config)
}
}
})
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ import { initMetaMask } from './support/initMetaMask'

let port: number

export default function configureBeforeSynpress(on: Cypress.PluginEvents, config: Cypress.PluginConfigOptions) {
export default function configureSynpress(on: Cypress.PluginEvents, config: Cypress.PluginConfigOptions) {
const browsers = config.browsers.filter((b) => b.name === 'chrome')
if (browsers.length === 0) {
throw new Error('No Chrome browser found in the configuration')

Unchanged files with check annotations Beta

/**
* The password of the MetaMask wallet.
*/
readonly password: string,

Check warning

Code scanning / CodeQL

Useless assignment to property Warning

This write to property 'password' is useless, since
another property write
always overrides it.
/**
* The extension ID of the MetaMask extension. Optional if no interaction with the dapp is required.
*/