Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Run on windows with cache #1161

Merged
merged 15 commits into from
Jul 9, 2024
Merged

✨ feat: Run on windows with cache #1161

merged 15 commits into from
Jul 9, 2024

Conversation

0xSero
Copy link
Contributor

@0xSero 0xSero commented Jul 2, 2024

Motivation and context

Add support for using Cache on x86 Windows OS

Does it fix any issue?

SYN-126

Other useful info

  • Built cache and ran tests on x86 Windows 11
  • Would like to see results on win10 but don't have win10 device

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 0:39am

@0xSero
Copy link
Contributor Author

0xSero commented Jul 2, 2024

file path management
file:///${filePath.replace(/\\/g, '/').replace(/^([a-zA-Z]):/, (_, drive) => drive.toLowerCase())}

@0xSero
Copy link
Contributor Author

0xSero commented Jul 2, 2024

@0xSero
Copy link
Contributor Author

0xSero commented Jul 3, 2024

    filepath = filepath.replace(/\\/g, '/')
    if (!filepath.startsWith('./')) filepath = './' + filepath
    return filepath
}```

Once located maybe we can reconvert?

@0xSero
Copy link
Contributor Author

0xSero commented Jul 3, 2024

Error is occurring specifically here:

https://github.com/egoist/tsup/blob/796fc5030f68f929fecde7c94732e9a586ba7508/src/index.ts#L120C38-L121C1

TSUP is using a library called globby, which isn't handling windows paths properly, despite TSUP not having an issue (,: going to try and figure out what to do here

Additionally seems like this issue requires us to use only forward slashes (,:

sindresorhus/globby#179

@0xSero
Copy link
Contributor Author

0xSero commented Jul 3, 2024

NOTE:

We need to update synpress-cache npm package and versioning in package.json before we merge this

@0xSero 0xSero marked this pull request as ready for review July 3, 2024 13:59
@0xSero 0xSero changed the base branch from new-dawn to new-dawn-dev July 9, 2024 09:16
@0xSero 0xSero merged commit 02d451e into new-dawn-dev Jul 9, 2024
11 checks passed
@0xSero 0xSero deleted the windows-cache branch July 9, 2024 09:16
@matstyler matstyler restored the windows-cache branch July 11, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant