✨ feat: Add keplr wallet support and shared utils package #1147

0xSero · 2024-06-12T14:53:04Z

Motivation and context

We want to support keplr wallet and the cosmos ecosystem, as well as Phantom to support the Solana ecosystem. Additionally we want to set a standard for multi-wallet cache support

Does it fix any issue?

Allows us to use multiple wallets with cache
Adds Keplr/cosmos support

Other useful info

I removed test/unit from wallets since we removed the duplicate prepareExtension wallet solely in sypress-cache and all the units are already tested in cache
Modified CLI to take a flag to decide on a wallet to use for cache
Added over all the necessary functions/pages/and tests to use as a base for keplr
Added 2 setup functions in keplr (Note: the cache library needs 2 setup files to work properly, consistently and produce the correct hash in cache and wallet)

Quality checklist

I have performed a self-review of my code.
If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

vercel · 2024-06-12T14:53:08Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
synpress	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 5, 2024 0:39am

wallets/keplr/src/KeplrWallet.ts

wallets/keplr/src/cypress/initKeplrWallet.ts

wallets/keplr/src/KeplrWallet.ts

wallets/keplr/src/fixtures/keplrFixtures.ts

wallets/keplr/src/cypress/initKeplrWallet.ts

wallets/keplr/src/playwright-kepler.ts

wallets/keplr/test/playwright/addAccount.spec.ts

wallets/keplr/src/fixtures/keplrFixtures.ts

wallets/keplr/src/KeplrWallet.ts

0xSero · 2024-07-01T10:00:11Z

Things to change:

Change the randomly generated ClassNames to somethings more stable
Maybe select all elements of a certain type and filter through them
Priority should be for text, or xpath, IDs, or test-ids

matstyler · 2024-07-02T22:38:18Z

wallets/metamask/tsconfig.json

  "extends": "./tsconfig.build.json",
  "compilerOptions": {
    "rootDir": ".",
    "exactOptionalPropertyTypes": false, // Allows for `undefined` in `playwright.config.ts`
-    "types": ["cypress"],


we will need that :)

matstyler · 2024-07-02T22:49:12Z

packages/cache/src/cli/cliEntrypoint.ts

+  let extensionNames = extensionsToSetup()
+
+  if (!extensionNames.length) {
+    extensionNames = ['Keplr']


shouldn't we use MetaMask as default?

matstyler · 2024-07-02T22:50:50Z

packages/cache/src/ensureCacheDirExists.ts

@@ -1,6 +1,6 @@
 import path from 'node:path'
 import fs from 'fs-extra'
-import { CACHE_DIR_NAME } from './constants'
+import { CACHE_DIR_NAME } from '../../cache/src/constants'


can we do "./ensureCacheDirExists"?

matstyler · 2024-07-02T22:51:24Z

packages/cache/src/index.ts

 export * from './downloadFile'
-export * from './unzipArchive'
+export * from '../../cache/src/unzipArchive'


why isn't it in the same "cache" directory?

matstyler · 2024-07-02T22:57:57Z

packages/cache/src/createCache.ts

@@ -1,6 +1,7 @@
 import { getUniqueWalletSetupFunctions } from './utils/getUniqueWalletSetupFunctions'
 import { triggerCacheCreation } from './utils/triggerCacheCreation'

+//@TODO: Make it so createCache can handle only one wallet setup function


can you elaborate?

For some reason when we only have 1 setup file, the hash generated in prepareExtension creates what would have been the the hash from the second item in the wallet setup functions array.

If there's 2 or more setup functions this behaviour does not happen (this is true for MM as well even before adding Keplr)

This will be tackled in a separate issue

matstyler · 2024-07-03T09:54:59Z

wallets/keplr/src/pages/NotificationPage/actions/acceptAccess.ts

+  await notificationPage.waitForLoadState('domcontentloaded')
+  await notificationPage.waitForSelector(notificationPageElements.approveButton)
+  await notificationPage.click(notificationPageElements.approveButton)
+  return true


matstyler · 2024-07-03T09:55:34Z

wallets/keplr/src/pages/HomePage/selectors/index.ts

@@ -0,0 +1,10 @@
+export const homePageElements = {
+  tokenNameLabel: (tokenName: string) => `:text-is("${tokenName}")`,


Suggested change

tokenNameLabel: (tokenName: string) => `:text-is("${tokenName}")`,

getTokenNameLabel: (tokenName: string) => `:text-is("${tokenName}")`,

matstyler · 2024-07-03T09:55:47Z

wallets/keplr/src/pages/HomePage/selectors/index.ts

+  newTokensFound: 'new token(s) found',
+  addChainsButton: 'Add Chains',
+  newTokensFoundSelector: 'text=new token(s) found',
+  walletSelectors: (chainName: string) => `img[alt="${chainName}"]`,


selectors? isn't it only one?

wallets/keplr/src/pages/LockPage/actions/importWallet.ts

matstyler · 2024-07-03T10:32:24Z

wallets/keplr/src/fixtures/keplrFixtures.ts

+    },
+
+    page: async ({ page }, use) => {
+      await page.goto('https://wallet.keplr.app/')


why not to use default page?

0xSero · 2024-07-03T14:00:30Z

NOTE:

We need to update synpress npm packages and versioning in package.json before we merge this

initial keplr set up

c5087d0

0xSero added the enhancement New feature or request label Jun 12, 2024

0xSero self-assigned this Jun 12, 2024

move over keplr set up

5829861

github-advanced-security bot found potential problems Jun 12, 2024

View reviewed changes

wallets/keplr/src/KeplrWallet.ts Fixed Show fixed Hide fixed

wallets/keplr/src/cypress/initKeplrWallet.ts Fixed Show fixed Hide fixed

vercel bot had a problem deploying to Preview June 12, 2024 15:20 Failure

more set up

4fd666f

vercel bot had a problem deploying to Preview June 12, 2024 16:02 Failure

github-advanced-security bot found potential problems Jun 12, 2024

View reviewed changes

wallets/keplr/src/KeplrWallet.ts Fixed Show fixed Hide fixed

init

60304a3

vercel bot had a problem deploying to Preview June 12, 2024 16:16 Failure

github-advanced-security bot found potential problems Jun 12, 2024

View reviewed changes

wallets/keplr/src/fixtures/keplrFixtures.ts Fixed Show fixed Hide fixed

wallets/keplr/src/cypress/initKeplrWallet.ts Fixed Show fixed Hide fixed

keplr extension install

0ec44d3

vercel bot had a problem deploying to Preview June 13, 2024 08:56 Failure

selectors

97091d6

vercel bot had a problem deploying to Preview June 13, 2024 09:43 Failure

playwright keplr set up

101c9ad

vercel bot had a problem deploying to Preview June 13, 2024 10:40 Failure

github-advanced-security bot found potential problems Jun 13, 2024

View reviewed changes

wallets/keplr/src/playwright-kepler.ts Fixed Show fixed Hide fixed

build set up

a5a6762

vercel bot deployed to Preview June 13, 2024 10:48 View deployment

prepare test

e8d0bd8

vercel bot deployed to Preview June 13, 2024 11:46 View deployment

github-advanced-security bot found potential problems Jun 13, 2024

View reviewed changes

wallets/keplr/test/playwright/addAccount.spec.ts Fixed Show fixed Hide fixed

prepare test

e1179ad

vercel bot deployed to Preview June 13, 2024 13:17 View deployment

github-advanced-security bot found potential problems Jun 13, 2024

View reviewed changes

set up cache

b39afcd

vercel bot deployed to Preview June 13, 2024 13:39 View deployment

done

630298b

vercel bot deployed to Preview June 24, 2024 16:26 View deployment

lint

1622f45

vercel bot deployed to Preview June 24, 2024 16:32 View deployment

remove unused

25559c8

vercel bot deployed to Preview June 24, 2024 16:34 View deployment

0xSero requested a review from matstyler June 24, 2024 16:35

Merge branch 'new-dawn' into feat/keplr-wallet

a0da307

vercel bot deployed to Preview July 1, 2024 09:56 View deployment

0xSero added 2 commits July 1, 2024 09:50

update selectors, need to publish versions on NPM

7376f3e

remove

97a91fc

vercel bot deployed to Preview July 1, 2024 13:52 View deployment

lint

6f6c783

vercel bot deployed to Preview July 1, 2024 13:53 View deployment

test

e428447

vercel bot deployed to Preview July 1, 2024 14:07 View deployment

matstyler reviewed Jul 3, 2024

View reviewed changes

0xSero marked this pull request as draft July 4, 2024 10:51

0xSero changed the title ~~✨ feat: Add keplr wallet support and shared utils package~~ ✨ feat: Add Keplr and Phantom support Jul 4, 2024

0xSero changed the title ~~✨ feat: Add Keplr and Phantom support~~ ✨ feat: Add keplr and phantom support Jul 4, 2024

0xSero changed the title ~~✨ feat: Add keplr and phantom support~~ ✨ feat: Add keplr wallet support Jul 4, 2024

0xSero changed the title ~~✨ feat: Add keplr wallet support~~ ✨ feat: Add keplr wallet support and shared utils package Jul 4, 2024

Merge branch 'new-dawn' into feat/keplr-wallet

78d6de9

vercel bot deployed to Preview July 5, 2024 12:26 View deployment

Merge branch 'new-dawn' into feat/keplr-wallet

49257de

vercel bot deployed to Preview July 5, 2024 12:39 View deployment

0xSero changed the base branch from new-dawn to new-dawn-dev July 9, 2024 15:55

0xSero closed this Jul 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ feat: Add keplr wallet support and shared utils package #1147

✨ feat: Add keplr wallet support and shared utils package #1147

0xSero commented Jun 12, 2024 •

edited

Loading

vercel bot commented Jun 12, 2024 •

edited

Loading

0xSero commented Jul 1, 2024

matstyler Jul 2, 2024

matstyler Jul 2, 2024

matstyler Jul 2, 2024

matstyler Jul 2, 2024

matstyler Jul 2, 2024

0xSero Jul 3, 2024 •

edited

Loading

matstyler Jul 3, 2024

matstyler Jul 3, 2024

matstyler Jul 3, 2024

matstyler Jul 3, 2024

0xSero commented Jul 3, 2024

		@@ -0,0 +1,10 @@
		export const homePageElements = {
		tokenNameLabel: (tokenName: string) => `:text-is("${tokenName}")`,

	tokenNameLabel: (tokenName: string) => `:text-is("${tokenName}")`,
	getTokenNameLabel: (tokenName: string) => `:text-is("${tokenName}")`,

✨ feat: Add keplr wallet support and shared utils package #1147

✨ feat: Add keplr wallet support and shared utils package #1147

Conversation

0xSero commented Jun 12, 2024 • edited Loading

Motivation and context

Does it fix any issue?

Other useful info

Quality checklist

vercel bot commented Jun 12, 2024 • edited Loading

0xSero commented Jul 1, 2024

Things to change:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xSero Jul 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xSero commented Jul 3, 2024

NOTE:

0xSero commented Jun 12, 2024 •

edited

Loading

vercel bot commented Jun 12, 2024 •

edited

Loading

0xSero Jul 3, 2024 •

edited

Loading