Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add renameAccount method #1145

Merged
merged 13 commits into from
Jun 24, 2024
Merged

Conversation

0xSero
Copy link
Contributor

@0xSero 0xSero commented Jun 11, 2024

Motivation and context

  • Allows us to name a metamask account

Does it fix any issue?

#(issue)

Other useful info

N/A

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 4:33pm

@0xSero 0xSero marked this pull request as draft June 11, 2024 11:47
@0xSero 0xSero marked this pull request as ready for review June 11, 2024 12:06
@0xSero 0xSero requested a review from drptbl June 11, 2024 12:38
drptbl
drptbl previously requested changes Jun 14, 2024
wallets/metamask/src/pages/HomePage/selectors/index.ts Outdated Show resolved Hide resolved
@0xSero 0xSero merged commit 23f5c7a into new-dawn Jun 24, 2024
9 checks passed
@0xSero 0xSero deleted the feat/add-rename-account-test branch June 24, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants