Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Resolved connectToDapp test issue #1128

Merged
merged 1 commit into from
May 8, 2024

Conversation

matstyler
Copy link
Collaborator

Motivation and context

Resolves tricky test case for the connectToDapp function.

Other useful info

N/A

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 6:04pm

@matstyler matstyler marked this pull request as ready for review May 8, 2024 18:04
@graphite-app graphite-app bot requested a review from drptbl May 8, 2024 18:04
Copy link

graphite-app bot commented May 8, 2024

TV gif. Steve Irwin the Crocodile Hunter looking down at a body of water, turns around and gives a double thumbs-up, mouthing 'that's good.' (Added via Giphy)

Copy link

graphite-app bot commented May 8, 2024

Graphite Automations

"Assign drptbl as reviewer" took an action on this PR • (05/08/24)

1 assignee was added and 1 reviewer was added to this PR based on 's automation.

"Post a GIF when PR approved" took an action on this PR • (05/08/24)

1 gif was posted to this PR based on 's automation.

@matstyler matstyler changed the title fix: connectToDapp accounts test 🐛 fix: Resolved connectToDapp test issue May 8, 2024
@matstyler matstyler enabled auto-merge (squash) May 8, 2024 18:06
@matstyler matstyler merged commit 2146ab3 into new-dawn May 8, 2024
9 of 10 checks passed
@matstyler matstyler deleted the fix/connectToDapp-tests branch May 8, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants