Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 feat: Use wallets as plugins & packages cleanup #1125

Merged
merged 20 commits into from
May 8, 2024

Conversation

matstyler
Copy link
Collaborator

Motivation and context

Clearly and concisely describe the feature added/isses being solved.

Does it fix any issue?

#(issue)

Other useful info

N/A

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 6:14pm

@matstyler matstyler changed the title Feat/wallets as plugins feat: use wallets as plugins May 3, 2024
@matstyler matstyler requested a review from drptbl May 3, 2024 13:35
@matstyler matstyler changed the title feat: use wallets as plugins 🎨 feat: use wallets as plugins May 3, 2024
@matstyler matstyler marked this pull request as ready for review May 3, 2024 13:44
Copy link

graphite-app bot commented May 3, 2024

Graphite Automations

"Assign drptbl as reviewer" took an action on this PR • (05/03/24)

1 assignee was added to this PR based on 's automation.

"Post a GIF when PR approved" took an action on this PR • (05/08/24)

1 gif was posted to this PR based on 's automation.

@matstyler matstyler changed the title 🎨 feat: use wallets as plugins 🎨 feat: Use wallets as plugins May 3, 2024
Copy link
Collaborator

@drptbl drptbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some comments, lets go through them on our Mondays call.

@matstyler matstyler requested a review from drptbl May 4, 2024 19:19
@matstyler matstyler changed the title 🎨 feat: Use wallets as plugins 🎨 feat: Use wallets as plugins & packages cleanup May 6, 2024
@drptbl drptbl merged commit 0f7378f into new-dawn May 8, 2024
10 checks passed
@drptbl drptbl deleted the feat/wallets-as-plugins branch May 8, 2024 11:03
Copy link

graphite-app bot commented May 8, 2024

Ad gif. Sitting in front of an old computer, '90s child actor Brent Rambo gives a robust thumbs up to the camera, his mouth a confident upside-down crescent. His autograph is superimposed onto the scene, giving the impression that his stamp of approval truly matters.  (Added via Giphy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants