Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Synpress with MetaMask mock #1123

Merged
merged 5 commits into from
Apr 8, 2024
Merged

✨ feat: Synpress with MetaMask mock #1123

merged 5 commits into from
Apr 8, 2024

Conversation

matstyler
Copy link
Collaborator

Motivation and context

Synpress with MetaMask mocked wallet.

Does it fix any issue?

https://linear.app/synpress/issue/SYN-71/mock-metamask-wallet-api

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

@matstyler matstyler requested a review from drptbl April 8, 2024 19:08
Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 9:43pm

Copy link

graphite-app bot commented Apr 8, 2024

Graphite Automations

"Assign drptbl as reviewer" took an action on this PR • (04/08/24)

1 assignee was added to this PR based on 's automation.

"Post a GIF when PR approved" took an action on this PR • (04/08/24)

1 gif was posted to this PR based on 's automation.

examples/new-dawn/test/e2e/00_mock.spec.ts Fixed Show fixed Hide fixed
/**
* The MetaMask tab page.
*/
readonly page: Page

Check warning

Code scanning / CodeQL

Useless assignment to property Warning

This write to property 'page' is useless, since
another property write
always overrides it.
@matstyler matstyler force-pushed the feat/metamask-mock branch from c47376c to 3f76c07 Compare April 8, 2024 19:35
@matstyler matstyler changed the title ✨ feat: Synpress with metamask mock ✨ feat: Synpress with MetaMask mock Apr 8, 2024
@drptbl drptbl merged commit 2519a8b into new-dawn Apr 8, 2024
12 checks passed
@drptbl drptbl deleted the feat/metamask-mock branch April 8, 2024 22:48
Copy link

graphite-app bot commented Apr 8, 2024

Added via Giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants