Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Watch token using EIP747 #1111

Merged
merged 1 commit into from
Mar 7, 2024
Merged

✨ feat: Watch token using EIP747 #1111

merged 1 commit into from
Mar 7, 2024

Conversation

matstyler
Copy link
Collaborator

@matstyler matstyler commented Feb 29, 2024

Motivation and context

Watch token using EIP747

Does it fix any issue?

https://linear.app/synpress/issue/SYN-65/watch-token-using-eip747

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️


Generated summary

TL;DR

This pull request adds a new end-to-end test for adding a new token using EIP747 in the MetaMask wallet.

What changed

A new test case has been added to the addNewToken.spec.ts file. This test case simulates the process of adding a new token using EIP747. It fills in the contract address, symbol, and decimals for the new token, clicks the watch button, and then checks that the token has been added successfully.

How to test

To test this change, you can run the end-to-end tests for the MetaMask wallet. The new test case should be included in the test suite. Ensure that the test passes and that it accurately represents the process of adding a new token using EIP747.

Why make this change

This change is necessary to ensure that the functionality for adding a new token using EIP747 is working as expected in the MetaMask wallet. By adding this test case, we can catch any potential issues or regressions with this feature in the future.

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview Feb 29, 2024 6:27pm

@matstyler matstyler requested a review from drptbl February 29, 2024 18:27
@drptbl drptbl merged commit 0f4a785 into new-dawn Mar 7, 2024
12 checks passed
@drptbl drptbl deleted the feat/eip747 branch March 7, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants