Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Encrypt/decrypt using MetaMask #1109

Merged
merged 2 commits into from
Feb 28, 2024
Merged

✨ feat: Encrypt/decrypt using MetaMask #1109

merged 2 commits into from
Feb 28, 2024

Conversation

matstyler
Copy link
Collaborator

@matstyler matstyler commented Feb 28, 2024

Motivation and context

Implemented encrypt/decrypt functionalities using MetaMask.

Does it fix any issue?

https://linear.app/synpress/issue/SYN-63/encryptdecrypt

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️


Generated summary

TL;DR

This pull request adds new methods to MetaMask class for adding new tokens, providing public encryption keys, and decrypting messages. It also includes new actions for encryption in the NotificationPage.

What changed

  • Added new methods addNewToken(), providePublicEncryptionKey(), and decrypt() to the MetaMask class.
  • Added new actions for encryption in the NotificationPage.
  • Created new files for encryption actions in the NotificationPage.

How to test

  1. Click on the 'getEncryptionKeyButton' button to provide a public encryption key.
  2. Verify that the encryption key is displayed correctly.
  3. Encrypt and decrypt a message by following the steps provided in the test cases.

Why make this change

  • This change introduces new functionality to MetaMask for handling encryption tasks.
  • The addition of encryption actions in the NotificationPage enhances the security features of the application.
  • These changes improve the overall user experience and security of MetaMask.

@matstyler matstyler requested a review from drptbl February 28, 2024 14:22
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 2:25pm

@drptbl drptbl merged commit c664eb7 into new-dawn Feb 28, 2024
12 checks passed
@drptbl drptbl deleted the feat/encryption branch February 28, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants