Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Get account address helper with missing token transfers #1107

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

matstyler
Copy link
Collaborator

@matstyler matstyler commented Feb 24, 2024

Motivation and context

Missing e2e tests for token transfers with a function to get account address.

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️


Generated summary

TL;DR

This pull request introduces a new feature to the MetaMask wallet that allows users to retrieve the current account address. This is achieved by adding a new method getAccountAddress to the MetaMask class and the corresponding action in the HomePage class.

What changed

  • A new method getAccountAddress was added to the MetaMask class.
  • A new action getAccountAddress was added to the HomePage class.
  • The HomePage class was updated to include the new getAccountAddress action.
  • The HomePage selectors were updated to include the selectors needed for the new action.
  • The e2e tests were updated to include tests for the new feature.

How to test

  1. Pull the changes from this branch to your local environment.
  2. Run the e2e tests using the command npm run test:e2e.
  3. All tests should pass, including the new tests for the getAccountAddress feature.

Why make this change

This change is necessary to allow users to retrieve their current account address from the MetaMask wallet. This is a common requirement for many dApps and will improve the usability of the wallet.

Copy link

vercel bot commented Feb 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2024 0:42am

@matstyler matstyler changed the title ✨ feat: Get account token helper with token transfers ✨ feat: Get account address helper with missing token transfers Feb 24, 2024
@drptbl drptbl self-requested a review February 25, 2024 00:42
@drptbl drptbl merged commit 6a65b9e into new-dawn Feb 25, 2024
12 checks passed
@drptbl drptbl deleted the feat/token-transfers branch February 25, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants