🔧 chore: Unified MetaMask Dapp ports #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matstyler
changed the title
matstyler
force-pushed
the
chore/unify-metamask-dapp-port
branch
from
45078eb to
0f2f55e
Compare
matstyler
force-pushed
the
chore/unify-metamask-dapp-port
branch
from
719630d to
4d2d348
Compare
matstyler
force-pushed
the
chore/unify-metamask-dapp-port
branch
from
4d2d348 to
2245158
Compare
drptbl
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
As we have two different ports defined for the same Dapp in our monorepo, it provokes confusion - for the playwright and for the users as well. We should unify this.
Does it fix any issue?
https://linear.app/synpress/issue/SYN-53/start-metamask-test-dapp-in-example-scenario
Quality checklist