Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat: Add renameAccount method #1084

Closed
wants to merge 12 commits into from
Closed

✨ feat: Add renameAccount method #1084

wants to merge 12 commits into from

Conversation

Seroxdesign
Copy link
Contributor

@Seroxdesign Seroxdesign commented Jan 25, 2024 •
edited
Loading

Motivation and context

Renaming wallets is important for managing financials

Clearly and concisely describe the feature added/isses being solved.

Does it fix any issue?

Adds functionality that isn't currently available in new dawn

#(issue)

Other useful info

N/A

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

@vercel Vercel
Copy link

vercel bot commented Jan 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 2:05pm

@Seroxdesign Seroxdesign marked this pull request as ready for review January 25, 2024 14:22
@duckception
Copy link
Contributor

Hey! Thanks for the PR! 🖤

It's perfect except for a few super small details 😇

@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024

@Seroxdesign is attempting to deploy a commit to the Synpress Team on Vercel.

A member of the Team first needs to authorize it.

@Seroxdesign
Copy link
Contributor Author

Hey! Thanks for the PR! 🖤

It's perfect except for a few super small details 😇

Thanks for taking the time to review, I pushed up a few changes that should make this more stable, specifically i removed the validation, made it so that I use a mouse click instead of an enter key, and removed a test spec I wrote for the English reserved names.

Good catches btw

@Seroxdesign Seroxdesign changed the title Rename Account functionality ✨ feat(metamask): Add support for renaming account Feb 3, 2024
@Seroxdesign Seroxdesign changed the title ✨ feat(metamask): Add support for renaming account ✨ feat(metamask): Add renameAccount method Feb 5, 2024
@Seroxdesign Seroxdesign changed the title ✨ feat(metamask): Add renameAccount method ✨ feat(metamask): Add renameAccount method Feb 5, 2024
@Seroxdesign
Copy link
Contributor Author

I ran lint and redid the title, hopefully this is ready to go (:

@duckception
Copy link
Contributor

@drptbl Can you handle this? Looks decent 👍

@Seroxdesign Seroxdesign changed the title ✨ feat(metamask): Add renameAccount method ✨ feat: Add renameAccount method Feb 12, 2024
@Seroxdesign
Copy link
Contributor Author

@drptbl can you please rerun this Validate Title check?
Last one should've been valid, not sure why it failed. Any idea?

@Seroxdesign
Copy link
Contributor Author

@duckception @drptbl either of you able to get this merged?
The naming convention is being followed from what I understand but if not lmk what i'm doing wrong.

@Seroxdesign Seroxdesign deleted the sero/rename-account branch June 11, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckception duckception duckception requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seroxdesign @duckception @drptbl