Fix localized Chrome's extension id (#928)

* Fix localized Chrome's extension id * Improve id handling --------- Co-authored-by: Piotr Frankowski <[email protected]>
Synthetixio · Oct 18, 2023 · ebeb450 · ebeb450
1 parent fc9b2aa
commit ebeb450
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/commands/playwright.js b/commands/playwright.js
@@ -57,6 +57,11 @@ module.exports = {
   activeTabName() {
     return activeTabName;
   },
+  async metamaskExtensionId() {
+    const metamaskExtensionData = (await module.exports.getExtensionsData())
+    .metamask;
+    return metamaskExtensionData.id;
+  },
   async setExpectInstance(expect) {
     expectInstance = expect;
   },
@@ -87,8 +92,7 @@ module.exports = {
     return true;
   },
   async assignWindows() {
-    const metamaskExtensionData = (await module.exports.getExtensionsData())
-      .metamask;
+    const metamaskExtensionId = await module.exports.metamaskExtensionId();
 
     let pages = await browser.contexts()[0].pages();
     for (const page of pages) {
@@ -97,21 +101,21 @@ module.exports = {
       } else if (
         page
           .url()
-          .includes(`chrome-extension://${metamaskExtensionData.id}/home.html`)
+          .includes(`chrome-extension://${metamaskExtensionId}/home.html`)
       ) {
         metamaskWindow = page;
       } else if (
         page
           .url()
           .includes(
-            `chrome-extension://${metamaskExtensionData.id}/notification.html`,
+            `chrome-extension://${metamaskExtensionId}/notification.html`,
           )
       ) {
         metamaskNotificationWindow = page;
       } else if (
         page
           .url()
-          .includes(`chrome-extension://${metamaskExtensionData.id}/popup.html`)
+          .includes(`chrome-extension://${metamaskExtensionId}/popup.html`)
       ) {
         metamaskPopupWindow = page;
       }
@@ -161,16 +165,15 @@ module.exports = {
     return true;
   },
   async switchToMetamaskNotification() {
-    const metamaskExtensionData = (await module.exports.getExtensionsData())
-      .metamask;
+    const metamaskExtensionId = await module.exports.metamaskExtensionId();
 
     let pages = await browser.contexts()[0].pages();
     for (const page of pages) {
       if (
         page
           .url()
           .includes(
-            `chrome-extension://${metamaskExtensionData.id}/notification.html`,
+            `chrome-extension://${metamaskExtensionId}/notification.html`,
           )
       ) {
         metamaskNotificationWindow = page;
@@ -337,15 +340,14 @@ module.exports = {
     }
   },
   async waitUntilStable(page) {
-    const metamaskExtensionData = (await module.exports.getExtensionsData())
-      .metamask;
+    const metamaskExtensionId = await module.exports.metamaskExtensionId();
 
     if (
       page &&
       page
         .url()
         .includes(
-          `chrome-extension://${metamaskExtensionData.id}/notification.html`,
+          `chrome-extension://${metamaskExtensionId}/notification.html`,
         )
     ) {
       await page.waitForLoadState('load');
@@ -477,7 +479,7 @@ module.exports = {
 
       const extensionId = (
         await extensionData.locator('#extension-id').textContent()
-      ).replace('ID: ', '');
+      ).split(': ')[1];
 
       extensionsData[extensionName] = {
         version: extensionVersion,