-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cops, bicbucstriim: update to depend on DSM 7.2 #6340
Conversation
- handle REQUIRED_MIN_DSM = 7.2 for noarch packages - add option to include noarch-7.2 packages in build workflow
@hgy59, guess this can be modified to also treat with BicBucStriim? |
@hgy59 the build failure is because the source file was changed. It now has the suffix of '-php82' in the filename so the whole file is now called: cops-3.2.2-php82.zip. Adjusting this in the cross/ should fix it. |
- source file was renamed
already found this for bicbucstriim but for cops I had the old one in the distrib folder... |
already done locally, but want to validate the new build matrix first. |
- use different name for noarch-7.2 to allow parallel 7.0 and 7.2 packages
- fix source url - use REQUIRED_MIN_DSM = 7.2 for PHP8.2 - remove SERVICE_USER (required for DSM 6 only)
Both packages published for DSM 7.2. Existing packages with PHP 8.2 and DSM 7.0 deactivated new (to allow manual installation, for the rare case a user wants to install cops or bicbucstriim on DSM 7.2 before those are visible in Package Center). |
@mreid-tt there is a small issue in regular builds, when changed packages require DSM 7.2. For manually triggered builds this is handled by separated options. |
@hgy59 a possible solution would be to add checks for the presence of packages by adding these lines:
right after this line: spksrc/.github/workflows/build.yml Line 172 in e145e72
Then, you could modify this line: spksrc/.github/workflows/build.yml Line 186 in e145e72
to say something like this:
|
* Amend build matrix for noarch-7.2 - Fixes incorrect inclusion of DSM 7.2 builds when only noarch packages are required (#6340) - Consolidated matrix logic into set-defaults as a single source of truth - Simplified and clarified manual build inputs for a better user experience - Removed redundant needs dependencies in downstream jobs * Update BicBucStriim to v3.6.3 * Update cops to v3.4.5
* cops: update to depend on DSM 7.2 (SynoCommunity#6339) - handle REQUIRED_MIN_DSM = 7.2 for noarch packages - source file was renamed * update build matrix for noarch-7.2 - add option to include noarch-7.2 packages in build workflow - use different name for noarch-7.2 to allow parallel 7.0 and 7.2 packages * bicbucstriim: update to depend on DSM 7.2 - fix source url - use REQUIRED_MIN_DSM = 7.2 for PHP8.2 - remove SERVICE_USER (required for DSM 6 only)
Description
noarch packages depending on PHP 8.2 require DSM 7.2 and packages must include this dependency.
So far we have those packages:
bugfixes:
Fixes #6339
Checklist
all-supported
completed successfullyType of change