Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libxml2 and libxslt #6329

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Update libxml2 and libxslt #6329

merged 7 commits into from
Nov 25, 2024

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Nov 23, 2024 •
edited
Loading

Description

  • libxml2: Update libxml2 from 2.9.14 to 2.12.9 using cmake & github
  • libxslt: Update from 1.1.39 to 1.1.42 and use cmake + github

Fixes: Current download source is failing and dating.

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@th0ma7 th0ma7 self-assigned this Nov 23, 2024
@hgy59
Copy link
Contributor

hgy59 commented Nov 24, 2024

@th0ma7 there was a temp hack to redirect downloads from download.gnome.org/sources to cdimage.debian.org/mirror/gnome.org/sources in #6288.

now this PR shows that synocli-devel and synocli-net fail to download glib-2.78.4.tar.xz from gnome.org.

the reason for this hack was an invalid mirror used to download from gnome.org.

you could try to revert the redirection in spksrc.download.mk...

@th0ma7
Copy link
Contributor Author

th0ma7 commented Nov 24, 2024

@hgy59 ah! that explains! Still, I'll use that as opportunity to update glib as well while at it.... and remove the redirect. Thnx.

@hgy59
Copy link
Contributor

hgy59 commented Nov 24, 2024

@hgy59 ah! that explains! Still, I'll use that as opportunity to update glib as well while at it.... and remove the redirect. Thnx.

the mirror error occurred mostly on older glib versions and not on latest, so this seems not an option.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Nov 24, 2024

the mirror error occurred mostly on older glib versions and not on latest, so this seems not an option.

Ths github source looks good and stable... I'll work on using that as source instead.

@hgy59
Copy link
Contributor

hgy59 commented Nov 24, 2024

BTW can we remove the xml and xslt tools? I can't imagine a package requires those.

in PLIST remove xmlcatalog and xmllint for libxml and xsltproc for libxsl.
there might be even an option to disable the build of such tools...

@th0ma7
Copy link
Contributor Author

th0ma7 commented Nov 24, 2024

humm... no fun https://gitlab.gnome.org/GNOME/glib/-/issues/2716#note_1534454
So github source doesn't have the gvdb submodule which requires additional steps.

Let's see if removing the download.gnome.org redirect suffice.

@th0ma7 th0ma7 changed the title libxml2: Update libxml2 from 2.9.14 to 2.12.9 using cmake & github Update libxml2 and libxslt Nov 24, 2024
@th0ma7 th0ma7 mentioned this pull request Nov 24, 2024
Open
19 tasks
@hgy59
Copy link
Contributor

hgy59 commented Nov 24, 2024

Let's see if removing the download.gnome.org redirect suffice.

you find additional info in #6288 (comment)

The faulty mirror “mirror2.sandyriver.net” is chosen randomly, so successful downloads are not proof that it will not be used another time.

@th0ma7 th0ma7 merged commit 86efc7d into SynoCommunity:master Nov 25, 2024
14 of 15 checks passed
@th0ma7 th0ma7 deleted the libxml2-update branch November 25, 2024 01:22
hgy59 added a commit to hgy59/spksrc that referenced this pull request Nov 25, 2024
@hgy59
icecast: fix build
b57953c 
- fix build of cross/icecast, broken by update of cross/libxml2 in SynoCommunity#6329
@hgy59 hgy59 mentioned this pull request Nov 25, 2024
Merged
6 tasks
hgy59 added a commit that referenced this pull request Nov 25, 2024
@hgy59
icecast: fix build (#6333)
bcc7174 
- fix build of cross/icecast, broken by update of cross/libxml2 in #6329
urosch pushed a commit to urosch/spksrc that referenced this pull request Dec 9, 2024
@th0ma7
Update libxml2 and libxslt (SynoCommunity#6329)
fa27024 
* libxml2: Update libxml2 from 2.9.14 to 2.12.9 using cmake & github

* libxml2: Update from 2.12.9 to 2.13.5 and disable readline

* libxslt: Update from 1.1.39 to 1.1.42 and use cmake + github

* download.mk: Remove download.gnome.org redirect

* libxml2: Remove xmlcatalog and xmllint

* libxslt: Remove xsltproc

* icecast: Mark as BROKEN
urosch pushed a commit to urosch/spksrc that referenced this pull request Dec 9, 2024
@hgy59
icecast: fix build (SynoCommunity#6333)
6e185e5 
- fix build of cross/icecast, broken by update of cross/libxml2 in SynoCommunity#6329
urosch pushed a commit to urosch/spksrc that referenced this pull request Dec 9, 2024
@th0ma7
Update libxml2 and libxslt (SynoCommunity#6329)
051c73b 
* libxml2: Update libxml2 from 2.9.14 to 2.12.9 using cmake & github

* libxml2: Update from 2.12.9 to 2.13.5 and disable readline

* libxslt: Update from 1.1.39 to 1.1.42 and use cmake + github

* download.mk: Remove download.gnome.org redirect

* libxml2: Remove xmlcatalog and xmllint

* libxslt: Remove xsltproc

* icecast: Mark as BROKEN
urosch pushed a commit to urosch/spksrc that referenced this pull request Dec 9, 2024
@hgy59
icecast: fix build (SynoCommunity#6333)
3d47f98 
- fix build of cross/icecast, broken by update of cross/libxml2 in SynoCommunity#6329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@th0ma7 th0ma7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@th0ma7 @hgy59