Test of Jellyseerr v2.0.1 #6294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @hgy59, I was attempting to build a Node.js app using the instructions from the source repo but I think I'm missing something. While it does build from my branch, it does not include the dependencies required to run the package. So if I install Node v20 (from Synology) and then run this command: I get errors like: So even though it does build and I see this in the log as being passed as a dependency, I don't know how to include it in the package. Or perhaps this isn't the right approach when dealing with Node.js? |
|
I guess, the instructions work only when built on the target system. Did you include the node_modules folder in the package? probably you need to call but my try with pnpm deploy faild with: If this package really has > 1 GB of dependent modules it will be too large for SynoCommunity anyway... |
mreid-tt
force-pushed
the
package-jellyseerr
branch
from
0bc7044 to
add33c6
Compare
|
@hgy59, I tried to include the node_modules manually but I still get errors when trying to run it. The manual inclusion may not be the best solution. I think there may be a path with this but will have to take some time to understand it: |
|
As an alternate approach I tried to do a manual build like what the instructions advises but using the same account and a local account (based on this guide) as follows:
So all in all, it appears possible to install but it takes forever so a pre-compiled version would be preferable. |
|
@th0ma7, the more I dive into this Node.js setup, the less confident I am that a single executable application is the best approach here. I’ll wrap up my research over the weekend, but I’m starting to think we should consider using npm more as a shared library manager, which is closer to its intended design. Including node_modules in a complex package like this can easily add up to several hundred megabytes, which ends up being larger than some .NET deployments! Normally, running npm install -g will throw permission errors, but this guide shows how to configure it to run globally without sudo. This brings up questions about management. So far, I’ve had to set up multiple environment variables which are tied to the package's internal service account. That won't be sustainable across multiple packages. With an updated SynoCommunity build for Node.js v20, there might be a way for the application to handle package management itself. While it may not be as modular as pip, it’s worth exploring. Another hurdle is that packages are only installed directly from the source code; I’m not sure if they can be triggered within a compiled package. Hopefully, there’s already a solution out there for this. Let me know if you’ve got any initial thoughts on it. |
|
I'm not used to npm nor node.js, perhaps @hgy59 has some more experience on this and can provide assistance. From a python wheel source code compilation standpoint, traditionally with pip it builds fine as long as they are pure python. Otherwise you require a full build environment which isn't available on our nas by default. However, we do now have a synocli-devel package which could in theory be used as it does provide an clang/llvm compiler, but that would only cover simpler cases. If that can help I do have preliminary code in my local branch to ease wheel building, although not yet ready for testing. Hopefully this will greatly simplify the wheel building experience but not sure this is what you are looking for for jellyfin? |
|
Thanks for the feedback, @th0ma7. Just to clarify, this is actually for Jellyseerr, not Jellyfin. While much of this code was borrowed from jellyfin-web — a Node.js-based app — the build process here differs significantly. From what I understand, jellyfin-web installs the front-end files, but it’s the Jellyfin .NET executable that actually runs the web server. |
|
As an experiment I installed the whole thing again in an Ubuntu VM and then I tried packaging using nexe. The process seemed successful as follows: Sample: Full log: It seems to build a nice executable file like this: But when I try to run it I get this: So some more work on the single executable route is needed. |
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing build of Node.js app
Fixes #
Checklist
all-supportedcompleted successfullyType of change