Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go2rtc 1.8.5 #5970

Merged
merged 5 commits into from
Feb 1, 2024
Merged

go2rtc 1.8.5 #5970

merged 5 commits into from
Feb 1, 2024

Conversation

skrashevich
Copy link
Contributor

@skrashevich skrashevich commented Jan 8, 2024 •
edited
Loading

Description

version update

The patch is needed to provide compatibility with go1.20
Appropriate PR in the main project repository: AlexxIT/go2rtc#865

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@skrashevich skrashevich marked this pull request as draft January 8, 2024 11:57
@skrashevich
feat(go2rtc): add patch to refactor homekit helpers and introduce `ma…
3500b8a 
…xByteSlice`

The commit introduces a new patch file for the go2rtc project which refactors functions in the `homekit/helpers.go` file. This patch replaces the usage of the external `slices` package with a newly added function `maxByteSlice` within the same file, streamlining the extraction of maximum profileID and level values from byte slices. The `PATCHES_LEVEL` variable is also added to the Makefile, likely indicating the system should apply one level of patches during build.
@skrashevich skrashevich marked this pull request as ready for review January 8, 2024 12:47
@hgy59
Copy link
Contributor

hgy59 commented Jan 8, 2024

@skrashevich we do not want to be a development environment for other packages.
Please wait until the upstream repo has implemented your solution and to not update the spk package with such patches.

@skrashevich
Copy link
Contributor Author

All patches have been removed, as compatibility with go1.20 is no longer required (due to #5981)

hgy59
hgy59 reviewed Jan 22, 2024
View reviewed changes
cross/go2rtc/Makefile Outdated Show resolved Hide resolved
hgy59
hgy59 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hgy59 hgy59 merged commit 8074a63 into SynoCommunity:master Feb 1, 2024
17 checks passed
@hgy59 hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgy59 hgy59 hgy59 approved these changes

Assignees
No one assigned
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skrashevich @hgy59