Update Gitea to v1.21.4

[wkobiela]

Description

This PR includes the following changes:

1. Update Gitea to v1.21.4
2. Use redesigned shared folder structure
3. Amend upgrade and install wizards

Fixes #5481

Checklist

• Build rule all-supported completed successfully
• New installation of package completed successfully
• Package upgrade completed successfully (Manually install the package again)
• Package functionality was tested
• Any needed documentation is updated/created

Type of change

• Package update

[wkobiela]

Gitea requires Go 1.21 or greater to build. You can get it at https://go.dev/dl/

#5930

[efussi]

@wkobiela what about updating Gitea to v1.20.5 which doesn't require a Go version update (as an intermediate step), so we don't have to wait for cloudflare/cloudflared#1054?

[wkobiela]

Trying to do that here #5931

[wkobiela]

As go was updated, trying to bump gitea further over 1.21.0 release

older PR with newest bump < 1.21.0 #5931

[wkobiela]

Tested on DSM7.1 x64
fresh install with mysql database working OK
update from 1.17.3 with mysql database -> to 1.21.4 working OK

[wkobiela]

Is there anything more I can do to merge this package?

[hgy59]

@wkobiela can you please update the check list in the description? So far no item is checked.

[wkobiela]

Updated. Tested on vm dsm7, don't have an option to test on dsm6 right now

[mreid-tt]

@wkobiela I've tested under DSM 6 and it seems to work okay. I see your note for upgrades to earlier versions and I had to manually edit my config using:

sudo vi /var/packages/gitea/var/conf.ini

This was to treat with the following warnings in the admin:

Deprecated config option `[server]` `LFS_CONTENT_PATH` present. Use `[lfs]` `PATH` instead. This fallback will be/has been removed in v1.19.0

Deprecated config option `[log]` `ROUTER` present. Use `[log]` `logger.router.MODE` instead. This fallback will be/has been removed in 1.21

Ideally, it would be nice to use sed to fix the config files for users but that's more of a nice to have. I've also added some suggestions above to make the installation wizard screen a bit more compact and cleaner looking.

All in all, the update seems to work well for clean installs as well as updates.

[wkobiela]

Ideally, it would be nice to use sed to fix the config files for users but that's more of a nice to have. I've also added some suggestions above to make the installation wizard screen a bit more compact and cleaner looking.

I suppose it would be nice, but hard to guess what custom changes in configuration file particular user made. (I guess that these two deprecated options are just initial setup options - all differences between clear setup of 1.17 vs upgrade to 1.21).

If it is okay, I would stick with information to update config.ini manually

[mreid-tt]

LGTM

@hgy59 any objections to me merging and publishing?

[hgy59]

@mreid-tt can you please publish this?

in my local env, building gitea fails with:

error obtaining VCS status: exit status 128
        Use -buildvcs=false to disable VCS stamping.

[mreid-tt]

@hgy59, the version has been published.