Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SABnzbd to 4.1.0, update UnRar to 6.23 and add par2cmdline-turbo #5905

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

Safihre
Copy link
Contributor

@Safihre Safihre commented Sep 27, 2023

Description

Update SABnzbd to 4.1.0.
Replace cross/par2cmdline by cross/par2cmdline-turbo (much faster)
Update UnRar (includes import CVE fixes)

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@mreid-tt
Copy link
Contributor

hey @Safihre, I downloaded the files from the build for x64-7.1 and noted that the archive contained python311 and bazarr in addition to sabnzbd. I don't know if this is expected behaviour or not. As for the package itself it upgraded successfully on my test DSM 7.2 and the package functioned as expected. We should be good to go.

@hgy59
Copy link
Contributor

hgy59 commented Sep 28, 2023

I downloaded the files from the build for x64-7.1 and noted that the archive contained python311 and bazarr in addition to sabnzbd. I don't know if this is expected behaviour or not.

@mreid-tt this is expected behaviour, since all packages depending on changes of a PR are built. You find a log of the packages to build in the github build action job Prepare for build in the step Evaluate dependencies as

===> PACKAGES to download references for: python311  bazarr sabnzbd squidguard  

Since the build action always builds python311 before dependent packages, we had to fix, that python311 is not published when publishing a dependent package (see #5874).

BTW: when a change triggers the build of a lot of packages (like cross/openssl3, cross/libxml2, ...) we often reach the github action limit of 6 hours...

Copy link
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Safihre Safihre merged commit d9578ee into SynoCommunity:master Sep 29, 2023
17 checks passed
@Safihre
Copy link
Contributor Author

Safihre commented Sep 29, 2023

Thanks!

@Safihre
Copy link
Contributor Author

Safihre commented Sep 29, 2023

If there are any issues with this release, I might miss them, so you can just assign them to me!

@th0ma7
Copy link
Contributor

th0ma7 commented Sep 29, 2023

Note that there is still the issue with ppc since moving to openssl 3.x and rust where it core dumps when python loads pyo3.

@Safihre
Copy link
Contributor Author

Safihre commented Sep 29, 2023

So I should not publish the package for qoric?

@th0ma7
Copy link
Contributor

th0ma7 commented Sep 29, 2023

Exactly, we had to disable all qoriq python packages since then. And i didn't had the cycles to find a proper fix yet (or permanently drop support or ask for help from pyo3 project)

@mreid-tt mreid-tt mentioned this pull request Jan 1, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants