-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ps3netsrv updated #5861
ps3netsrv updated #5861
Conversation
Updated to v1.47.45 with ps3netsrv 20220813
@Hirador please have a look at the file It is not a valid digests file. you should be able to create the correct file with |
Hey I’ve thought about giving the chance to the user to set a custom port to the server, with a disclaimer where they can check which port is used in other Synocommunity’s packages (I know that this package has a port conflict with the Synology Calendar CalDAV). The fact is, the default port that the clients use to connect to this server is 38008, but can be changed with a custom one, so I’m planning to do it in the near future but for this update, I’m just leaving the default one set |
My fault, I’ve actually made the make digest command but something may have got wrong in the process |
Fixed the issue with the digests file |
It is not possible to make the port configurable. Each package has to use exclusive ports. As port 38008 conflicts with the synology calendar package, we should change this port now. |
@hgy59 If it is strictly necessary, I agree with the port changing even if I would really prefer to leave the default one, just because the clients need to be modified so is no more “plug and play”. Confirm to me that the port 14167 is usable and I’m going to edit the package in few minutes setting the default port to 14167 Also, where you think i can insert a warning to the users telling them to change the port client side? in the DESCRIPTION field? |
Please confirm me what I’ve said so that we can go live as soon as possible |
Changed default port as requested and added a disclaimer on the description to change default port client side
Changed the port, please continue the checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updated to v1.47.45 with ps3netsrv 20220813 for DSM's versions: DSM-6.2.4 -> DSM-7.1
Description
1 - Updated the variables found on "spksrc/spk/ps3netsrv" and " spksrc/cross/ps3netsrv" to match the current version (v1.47.45 with ps3netsrv 20220813) of aldostools's ps3netsrv
2 - made "make all-supported",
3 - created .spk for my Architecture (arch-armada370)
4 - Made some tests with the updated version of the ps3netsrv
5 - Cleaned everything up for the pull request (make clean on both spksrc/spk/ps3netsrv and spksrc/cross/ps3netsrv)
Closes #5751
Checklist
all-supported
completed successfullyType of change