Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ps3netsrv updated #5861

Merged
merged 3 commits into from
Sep 24, 2023
Merged

ps3netsrv updated #5861

merged 3 commits into from
Sep 24, 2023

Conversation

Hirador
Copy link
Contributor

@Hirador Hirador commented Aug 30, 2023

Updated to v1.47.45 with ps3netsrv 20220813 for DSM's versions: DSM-6.2.4 -> DSM-7.1

Description

1 - Updated the variables found on "spksrc/spk/ps3netsrv" and " spksrc/cross/ps3netsrv" to match the current version (v1.47.45 with ps3netsrv 20220813) of aldostools's ps3netsrv

2 - made "make all-supported",

3 - created .spk for my Architecture (arch-armada370)

4 - Made some tests with the updated version of the ps3netsrv

5 - Cleaned everything up for the pull request (make clean on both spksrc/spk/ps3netsrv and spksrc/cross/ps3netsrv)

Closes #5751

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

Updated to v1.47.45 with ps3netsrv 20220813
@hgy59
Copy link
Contributor

hgy59 commented Aug 30, 2023

@Hirador thanks for providing this update.

What do you think about changing the port for this package? (see #5751)

@hgy59
Copy link
Contributor

hgy59 commented Aug 30, 2023

@Hirador please have a look at the file /spksrc/cross/p3netsrv/digests

It is not a valid digests file.

you should be able to create the correct file with make clean && make digests in cross/ps3netsrv folder

@Hirador
Copy link
Contributor Author

Hirador commented Aug 31, 2023

@Hirador thanks for providing this update.

What do you think about changing the port for this package? (see #5751)

Hey I’ve thought about giving the chance to the user to set a custom port to the server, with a disclaimer where they can check which port is used in other Synocommunity’s packages (I know that this package has a port conflict with the Synology Calendar CalDAV). The fact is, the default port that the clients use to connect to this server is 38008, but can be changed with a custom one, so I’m planning to do it in the near future but for this update, I’m just leaving the default one set

@Hirador
Copy link
Contributor Author

Hirador commented Aug 31, 2023

@Hirador please have a look at the file /spksrc/cross/p3netsrv/digests

It is not a valid digests file.

you should be able to create the correct file with make clean && make digests in cross/ps3netsrv folder

My fault, I’ve actually made the make digest command but something may have got wrong in the process

@Hirador
Copy link
Contributor Author

Hirador commented Aug 31, 2023

@Hirador please have a look at the file /spksrc/cross/p3netsrv/digests

It is not a valid digests file.

you should be able to create the correct file with make clean && make digests in cross/ps3netsrv folder

Fixed the issue with the digests file

@hgy59
Copy link
Contributor

hgy59 commented Aug 31, 2023

Hey I’ve thought about giving the chance to the user to set a custom port to the server, with a disclaimer where they can check which port is used in other Synocommunity’s packages (I know that this package has a port conflict with the Synology Calendar CalDAV). The fact is, the default port that the clients use to connect to this server is 38008, but can be changed with a custom one, so I’m planning to do it in the near future but for this update, I’m just leaving the default one set

It is not possible to make the port configurable. Each package has to use exclusive ports. As port 38008 conflicts with the synology calendar package, we should change this port now.

@Hirador
Copy link
Contributor Author

Hirador commented Aug 31, 2023

Hey I’ve thought about giving the chance to the user to set a custom port to the server, with a disclaimer where they can check which port is used in other Synocommunity’s packages (I know that this package has a port conflict with the Synology Calendar CalDAV). The fact is, the default port that the clients use to connect to this server is 38008, but can be changed with a custom one, so I’m planning to do it in the near future but for this update, I’m just leaving the default one set

It is not possible to make the port configurable. Each package has to use exclusive ports. As port 38008 conflicts with the synology calendar package, we should change this port now.

@hgy59 If it is strictly necessary, I agree with the port changing even if I would really prefer to leave the default one, just because the clients need to be modified so is no more “plug and play”.

Confirm to me that the port 14167 is usable and I’m going to edit the package in few minutes setting the default port to 14167

Also, where you think i can insert a warning to the users telling them to change the port client side? in the DESCRIPTION field?

@Hirador
Copy link
Contributor Author

Hirador commented Sep 5, 2023

Hey I’ve thought about giving the chance to the user to set a custom port to the server, with a disclaimer where they can check which port is used in other Synocommunity’s packages (I know that this package has a port conflict with the Synology Calendar CalDAV). The fact is, the default port that the clients use to connect to this server is 38008, but can be changed with a custom one, so I’m planning to do it in the near future but for this update, I’m just leaving the default one set

It is not possible to make the port configurable. Each package has to use exclusive ports. As port 38008 conflicts with the synology calendar package, we should change this port now.

Please confirm me what I’ve said so that we can go live as soon as possible

Changed default port as requested and added a disclaimer on the description to change default port client side
@Hirador
Copy link
Contributor Author

Hirador commented Sep 20, 2023

Hey I’ve thought about giving the chance to the user to set a custom port to the server, with a disclaimer where they can check which port is used in other Synocommunity’s packages (I know that this package has a port conflict with the Synology Calendar CalDAV). The fact is, the default port that the clients use to connect to this server is 38008, but can be changed with a custom one, so I’m planning to do it in the near future but for this update, I’m just leaving the default one set

It is not possible to make the port configurable. Each package has to use exclusive ports. As port 38008 conflicts with the synology calendar package, we should change this port now.

Changed the port, please continue the checks

Copy link
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hgy59 hgy59 merged commit 43ac98b into SynoCommunity:master Sep 24, 2023
@Hirador Hirador changed the title ps3netsrv upadated ps3netsrv updated May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ps3netsrv default port conflicts with Synology Calendar CalDAV port
2 participants