-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dockerfile to bookworm #5781
Conversation
Required for 7.2 builds, as some tools (bat) rely on the newer glibc shipped on it (2.33). Unfortunately this means python2 has to go, since it's well out of support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thnx for your contribution, it really is appreciated.
Two things that cones to mind:
- Meson: probably best to maintain it ourselves through pip install as we can evolve the version more quickly than debian may be.
- The publishing part used to be python2 specific from what i recall. Not sure if this will work with py3 and or if it needs adjusting? @hgy59 any idea?
Edit: also, all documentation needs to be updated to reflect this change. This is mainly the master readme.
@th0ma7, @jisakiel it is not a solution to update the dev env (i.e. dockerfile) to the brand new Debian 12. All builds must never depend on a library version in the dev env. All rust tools fail to build for DSM 7.2 with errors like:
and
|
That was my point though - by moving the build environment to something with a newer libc (well, same 2.36, https://packages.debian.org/source/bookworm/glibc ) you pretty much bypass this problem. And I'd trust both libstdc++ and glibc's backwards compatibility, so that any older toolchains you might want will still work, leaving aside gcc becoming stricter over time. The alternative to that is a full bootstrap of every native toolchain, which in fairness might be better, but it will definitely be slower to get up and running. Think the 3 stage gcc, glibc, etc. I've successfully built synocli-files with this dockerfile for a 7.2-apollolake target. |
this PR got obsolete due #6183 |
Required for 7.2 builds in my tried experience, as some tools (bat) seemingly relied on the newer glibc shipped on the toolchain (2.33). Unfortunately this means python2 has to go, since it's well out of support. I'm uncertain of the impact of building (but I'd argue, given python2 is well out of support by now, if it's really needed it should be shipped in native/ instead).
Used to build synocli-files (what I was /actually/ trying here, some serious yak shaving in between) for 7.2 and arch-apollolake successfully.
Checklist
all-supported
completed successfullyType of change